tsa: base support #8273
Open
tsa: base support #8273
+290
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance Measurements ⏳
|
ripatel-fd
reviewed
Feb 12, 2026
|
|
||
| static inline void | ||
| fd_rwlock_write( fd_rwlock_t * lock ) { | ||
| fd_rwlock_write( fd_rwlock_t * lock ) FD_ACQUIRE( lock ) FD_NO_THREAD_SAFETY_ANALYSIS { |
Contributor
Author
There was a problem hiding this comment.
To suppress TSA checks inside the lock primitive implementation itself, while still keeping lock state tracking for callers. This is the common way to annotate the lock itself, see e.g. https://github.com/torvalds/linux/blob/master/tools/perf/util/mutex.c#L58
Introduces basic Thread Safety Analyser support. In contrast to #7189, this does only adds support + a script to see the TSA warnings. As discussed offline with @ripatel-fd, follow up PRs will add annotations support to individual components. Later with the follow-up PRs merged we can decide if we want to run TSA on every PR, or if we want to use the sarif v2 output from the checker script and feed it into GitHub code scanning in nightly.
two-heart
force-pushed
the
two-heart/tsa-base
branch
from
790c130 to
600e655
Compare
Performance Measurements ⏳
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces basic Thread Safety Analyser support. In contrast to #7189, this does only adds support + a script to see the TSA warnings. As discussed offline with @ripatel-fd, follow up PRs will add annotations support to individual components. Later with the follow-up PRs merged we can decide if we want to run TSA on every PR, or if we want to use the sarif v2 output from the checker script and feed it into GitHub code scanning in nightly.