shred: correctly compute feature activation slot for turbine features#8277
Merged
anwayde merged 1 commit intofiredancer-io:v0.8from Feb 13, 2026
Merged
Conversation
0x0ece
requested review from
alpeng-jump,
anwayde,
jherrera-jump,
mmcgee-jump and
ptaffet-jump
as code owners
0x0ece
force-pushed
the
0x0ece/v0.8-new-shred-feat-gates
branch
from
cbb30c0 to
d98c2e7
Compare
topointon-jump
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same as 8c21385 but rebased on v0.8.
Note: the fn
fd_shred_get_feature_activation_slot0is getting unused (code for full firedancer is not in v0.8 yet), so I just removed it here.The
test_xdp_tile1failing is in v0.8 and it's full firedancer code, unrelated to this PR.