Conversation
|
Performance Measurements ⏳
|
| cJSON const * id, | ||
| cJSON const * params ) { | ||
| if( FD_UNLIKELY( ctx->processed_idx==ULONG_MAX || ctx->banks[ ctx->processed_idx ].slot==ULONG_MAX ) ) return (fd_http_server_response_t){ .status = 500 }; | ||
| if( FD_UNLIKELY( ctx->processed_idx==ULONG_MAX || ctx->banks[ ctx->processed_idx ].slot==ULONG_MAX ) ) { |
There was a problem hiding this comment.
Don't love using a special code for this though ... we should match agave behavior if the snapshot isn't loaded yet or whatever (probably, the rpc doesn't accept connections until then?)
There was a problem hiding this comment.
is 500 for agave conformance
no, I'll change the behavior here to match
|
|
||
| [development.genesis] | ||
| fund_initial_accounts = 32768 | ||
| fund_initial_accounts = 1000 |
There was a problem hiding this comment.
See commit description
There was a problem hiding this comment.
Any larger and fd_genesis_parse.c breaks
There was a problem hiding this comment.
Can you fix fd_genesis_parse ?
|
@mmcgee-jump @jherrera-jump Are you ok with merging this as a quick fix? I just wanted a branch with bench working. The HTTP 503 hack is obviously ugly and not conformant, but at least it doesn't crash Alternatively, maybe we can fix the underlying bugs properly?
|
Fixes bench-zen4-128core. Does 600k TPS on my box, needs further tuning. - Introduce HTTP code 503 for when RPC is not yet ready (no bank), fixes crash in bencho - Enable sandbox when watch is disabled (seems to work fine) - Add support for `firedancer-dev mem --topo bench` - Drop bench genesis account configs to avoid hardcoded limit in fd_genesis_parse
ripatel-fd
force-pushed
the
ripatel/fix-bench
branch
from
50e0686 to
ceac7cd
Compare
Performance Measurements ⏳
|
|
Sure, fine with it if we file an issue to track fix |
4 participants
Fixes bench-zen4-128core. Does 600k TPS on my box, needs further
tuning.
fixes crash in bencho
firedancer-dev mem --topo benchfd_genesis_parse