Skip to content

rpc-client: fix uninit field#8305

Merged
mmcgee-jump merged 1 commit intomainfrom
intrigus/fix/uninit-revents-rpc-client
Feb 13, 2026
Merged

rpc-client: fix uninit field#8305
mmcgee-jump merged 1 commit intomainfrom
intrigus/fix/uninit-revents-rpc-client

Conversation

@intrigus-lgtm
Copy link
Contributor

Fixes an MSAN violation when running test_rpc_client.

test_rpc_client      ==1275203==WARNING: MemorySanitizer: use-of-uninitialized-value
 test_rpc_client          #0 0x565010096cf5 in fd_rpc_client_service /home/sg/firedancer/src/app/shared_dev/rpc_client/fd_rpc_client.c:294:9
test_rpc_client          #1 0x5650100973db in fd_rpc_client_status /home/sg/firedancer/src/app/shared_dev/rpc_client/fd_rpc_client.c:358:5
test_rpc_client          #2 0x5650100943b9 in main /home/sg/firedancer/src/app/shared_dev/rpc_client/test_rpc_client.c:180:41
test_rpc_client          #3 0x7f2bc3607ca7 in __libc_start_call_main csu/../sysdeps/nptl/libc_start_call_main.h:58:16
test_rpc_client          #4 0x7f2bc3607d64 in __libc_start_main csu/../csu/libc-start.c:360:3
test_rpc_client          #5 0x56500fff6690 in _start (/home/sg/firedancer/build/msan/unit-test/test_rpc_client+0x38690)
test_rpc_client      
test_rpc_client      SUMMARY: MemorySanitizer: use-of-uninitialized-value /home/sg/firedancer/src/app/shared_dev/rpc_client/fd_rpc_client.c:294:9 in fd_rpc_client_service

Fixes an MSAN violation when running test_rpc_client
@github-actions
Copy link

Performance Measurements ⏳

Suite Baseline New Change
backtest mainnet-368528500-perf per slot 0.062546 s 0.063382 s 1.337%
backtest mainnet-368528500-perf snapshot load 3.42 s 2.252 s -34.152%
backtest mainnet-368528500-perf total elapsed 62.546319 s 63.382389 s 1.337%
firedancer mem usage with mainnet.toml 987.33 GiB 987.33 GiB 0.000%

@mmcgee-jump mmcgee-jump merged commit 7dddb16 into main Feb 13, 2026
13 checks passed
@mmcgee-jump mmcgee-jump deleted the intrigus/fix/uninit-revents-rpc-client branch February 13, 2026 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants