-
Notifications
You must be signed in to change notification settings - Fork 7
Implement HDivTrace as a macroelement #151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release
Are you sure you want to change the base?
Conversation
5cce2af to
be3bd4e
Compare
b75d387 to
4f967ba
Compare
80e1fc9 to
9771213
Compare
rckirby
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems very pervasive, and not clear sometimes what's cleanup versus what's needed for the functionality. Were generalizations (say, to Lagrange) really needed to support this? Maybe it's not surprising if trying to do H(div) traces as a macro element spawns a bunch of problems way down the chain that we hadn't thought of.
|
Passing Firedrake CI firedrakeproject/firedrake#4429 |
I agree, this required to enhance ExpansionSet and LagrangeExpansionSet (the barycentric interpolation code, not the CiarletElement) to deal with codimension 1 (or higher) facets. I think regardless on whether or not we want to reimplement HDiv Trace as a macroelement, these enhacements should be kept. |
This PR enables macroelements defined on subcomplexes of the reference complex.
As a result we can reimplement
HDivTraceas a nodalCiarletElement