Skip to content

Conversation

@pbrubeck
Copy link

@pbrubeck pbrubeck commented Jul 3, 2025

This PR enables macroelements defined on subcomplexes of the reference complex.

As a result we can reimplement HDivTrace as a nodal CiarletElement

HDivTrace(ref_el, k) := DiscontinuousLagrange(TraceSimplicialComplex(ref_el), k)

@pbrubeck pbrubeck requested a review from rckirby July 3, 2025 11:27
@pbrubeck pbrubeck force-pushed the pbrubeck/trace branch 3 times, most recently from 5cce2af to be3bd4e Compare July 3, 2025 15:16
@pbrubeck pbrubeck force-pushed the pbrubeck/trace branch 2 times, most recently from b75d387 to 4f967ba Compare July 5, 2025 14:10
@pbrubeck pbrubeck force-pushed the pbrubeck/trace branch 2 times, most recently from 80e1fc9 to 9771213 Compare July 7, 2025 09:24
Copy link

@rckirby rckirby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems very pervasive, and not clear sometimes what's cleanup versus what's needed for the functionality. Were generalizations (say, to Lagrange) really needed to support this? Maybe it's not surprising if trying to do H(div) traces as a macro element spawns a bunch of problems way down the chain that we hadn't thought of.

@pbrubeck
Copy link
Author

pbrubeck commented Jul 9, 2025

Passing Firedrake CI firedrakeproject/firedrake#4429

@pbrubeck
Copy link
Author

pbrubeck commented Jul 9, 2025

This seems very pervasive, and not clear sometimes what's cleanup versus what's needed for the functionality. Were generalizations (say, to Lagrange) really needed to support this? Maybe it's not surprising if trying to do H(div) traces as a macro element spawns a bunch of problems way down the chain that we hadn't thought of.

I agree, this required to enhance ExpansionSet and LagrangeExpansionSet (the barycentric interpolation code, not the CiarletElement) to deal with codimension 1 (or higher) facets.

I think regardless on whether or not we want to reimplement HDiv Trace as a macroelement, these enhacements should be kept.

Base automatically changed from pbrubeck/bubble-variant to release July 10, 2025 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants