Skip to content

Add quadratures from gen-quad #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
pbrubeck wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add quadratures from gen-quad #89

pbrubeck wants to merge 4 commits into from

Conversation

@pbrubeck
Copy link

@pbrubeck pbrubeck commented Oct 16, 2024 •
edited
Loading

Degree 16 - 22 tetrahedral quadrature rules computed with https://github.com/arkslobodkins/gen-quad

@pbrubeck
Copy link
Author

pbrubeck commented Oct 16, 2024

@wence- how should we give credit to the author?

wence-
wence- reviewed Oct 16, 2024
View reviewed changes
FIAT/gen_quad_data.py
@@ -0,0 +1,5823 @@
# GENERATED, DO NOT EDIT
# Slobodkins-Tausch quadratures
Copy link

@wence- wence- Oct 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest linking to the code repo (with a commit hash), so that someone else knows what was run to generate this.

wence-
wence- reviewed Oct 16, 2024
View reviewed changes
FIAT/quadrature_schemes.py
Comment on lines +336 to +337
def gen_quad_simplex(dim):
ref_el = symmetric_simplex(dim)
Copy link

@wence- wence- Oct 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the citation here as well?

@wence-
Copy link

wence- commented Oct 16, 2024

@wence- how should we give credit to the author?

We don't currently hook the Citations mechanism up in FIAT. Maybe we should. Then we could register all the citations for quadrature rules and it would be automatic for -citations.

rckirby
rckirby reviewed Aug 8, 2025
View reviewed changes
Copy link

@rckirby rckirby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still of interest? There were discussions of citations. FIAT never picked up the petsc citation engine, but FInAT uses it and then got stuck inside of FIAT. Maybe it's time to pick that back up.

@pbrubeck
Copy link
Author

pbrubeck commented Aug 8, 2025

We cannot merge this yet as we need to be able to generate the tables automatically.

@connorjward
Copy link

connorjward commented Aug 8, 2025

We should move the citations tool to petsctools. Then it could get used here. It would make FIAT depend on petsc4py though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wence- wence- wence- left review comments

@rckirby rckirby rckirby left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pbrubeck @wence- @connorjward @rckirby