Fieldsplit: update MatNest Jacobian and support bcs on AssembledMatrix #4708
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbrubeck
force-pushed
the
pbrubeck/fix/nest-fieldsplit
branch
from
7c9dfcc to
aaabace
Compare
pbrubeck
changed the title
pbrubeck
commented
Nov 5, 2025
JHopeCollins
reviewed
Nov 5, 2025
pbrubeck
commented
Nov 5, 2025
pbrubeck
force-pushed
the
pbrubeck/fix/nest-fieldsplit
branch
from
abddfda to
4ab9490
Compare
leo-collins
reviewed
Dec 12, 2025
| if bc_temp is not None: | ||
| bcs.append(bc_temp) | ||
|
|
||
| return AssembledMatrix(form or tuple(args), tuple(bcs), submat) |
Contributor
There was a problem hiding this comment.
If we know what form is then this should be a Matrix, not an AssembledMatrix?
Contributor
Author
There was a problem hiding this comment.
maybe we should have a dispatcher mechanism get_matrix that decides which subclass to return
pbrubeck
force-pushed
the
pbrubeck/fix/nest-fieldsplit
branch
from
9f34240 to
754750b
Compare
pbrubeck
force-pushed
the
pbrubeck/fix/nest-fieldsplit
branch
from
754750b to
0a3fa46
Compare
pbrubeck
commented
Dec 16, 2025
| elif isinstance(bc, EquationBCSplit): | ||
| row_field, col_field = argument_indices | ||
| bc_temp = bc.reconstruct(field=field, V=V, row_field=row_field, col_field=col_field, use_split=True) | ||
| bc_temp = None |
Contributor
Author
There was a problem hiding this comment.
Suggested change
| bc_temp = None |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4687
Depends on https://gitlab.com/petsc/petsc/-/merge_requests/8860 to trigger preconditioner update for a MatNest with more than one field on a block of the fieldsplit.
Also fixes fieldsplit for
AssembledMatrixwith bcsCleanup
create_subdmindmhooks.py