Function space method to create broken function space. #4773
+60
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjward
reviewed
Dec 10, 2025
Co-authored-by: Connor Ward <c.ward20@imperial.ac.uk>
jrmaddison
reviewed
Dec 10, 2025
…rakeproject/firedrake into JHopeCollins/broken-function-space
JHopeCollins
commented
Dec 10, 2025
pbrubeck
approved these changes
Dec 11, 2025
Contributor
|
This should not have been merged. All of the tests were failing due to unrelated changes but critically this introduced a docs build failure. |
Contributor
I'll get the docbuild fixed in an analogous PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to review on #4716 .
This method returns an equivalent function space built using
finat.ufl.BrokenElement(self.ufl_element).Depends on firedrakeproject/fiat#201Merged.