Assembly of matfree interpolation operator #4778
Open
+302
−204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leo-collins
force-pushed
the
leo/assemble-matfree-interpolate
branch
from
57e5d2d to
5019974
Compare
pbrubeck
reviewed
Dec 12, 2025
pbrubeck
reviewed
Dec 12, 2025
| submat = o.petscmat.createSubMatrix(*ises) | ||
| bcs = () | ||
| return AssembledMatrix(tuple(args), bcs, submat) | ||
| return AssembledMatrix(tuple(args), submat) |
Contributor
There was a problem hiding this comment.
What happened to the BCs?
Contributor
There was a problem hiding this comment.
BTW, this will be fixed in https://github.com/firedrakeproject/firedrake/pull/4708/files
Contributor
Author
There was a problem hiding this comment.
BCs are an optional argument now
Contributor
There was a problem hiding this comment.
Better to not change this line to avoid conflicts
pbrubeck
reviewed
Dec 12, 2025
pbrubeck
reviewed
Dec 12, 2025
pbrubeck
reviewed
Dec 12, 2025
pbrubeck
reviewed
Dec 14, 2025
pbrubeck
reviewed
Dec 14, 2025
update comment
leo-collins
force-pushed
the
leo/assemble-matfree-interpolate
branch
from
75de8e2 to
5464cce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow assembly of matfree interpolation operators by passing
mat_type="matfree".Also changes the interfaces to the matrix classes and
ImplicitMatrixContextto make them simpler.