Merge upstream #28
Merged
Merge upstream #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Be explicit about what args are accepted. * fetch_insn_id -> prefetch_insn_id * program -> t_unit
Closes gh-858
* Changed to update the inames of the instructions that do not access an inames, yet, are nested within the iname to be duplicated.
Also drop _git_rev mechanism
inducer/loopy#694 Co-authored-by: Matthias Diener <mdiener@illinois.edu> Co-authored-by: Andreas Kloeckner <inform@tiker.net>
Co-authored-by: Andreas Kloeckner <inform@tiker.net>
On Python 3.12, this provokes a stack overflow in the scheduler. It is
not quite clear why that's the case; pure-Python recursion even with
generators seems to respond well to setrecursionlimit():
```py
def f(n):
if n:
yield from f(n-1)
else:
yield 5
import sys
sys.setrecursionlimit(3500)
print(list(f(3400)))
```
That said, there have been [behavior](python/cpython#96510)
[changes](python/cpython#112215)
in Py3.12 in this regard, but it is not clear what exactly
about Loopy's behavior makes it fall into the 'bad' case.
* Require that happens_after is not mutable * Tweak type tests for happens_after --------- Co-authored-by: Andreas Kloeckner <inform@tiker.net>
…it once and also defines the pack argument.
This restores compatibility with pymbolic 2022.2 x-ref: #27
Contributor
|
I think this already broke 3.8 and 3.9; see firedrakeproject/tsfc#327. Shall we just drop 3.8 and 3.9? |
Contributor
Author
Ah. That's a bit frustrating. I guess so. David said that that was fine this is just happening earlier than I expected. |
Contributor
Author
|
I will update the website accordingly (and also post to Slack). |
Contributor
|
Eeek, sorry about that! That was not intentional. Should you want to restore 3.8 compatibility for now, the fix is straightforward. This: ToShapeLikeConvertible: TypeAlias = (Tuple[ExpressionT | str, ...]
| ExpressionT | type[auto] | str | tuple[str, ...])should become: ToShapeLikeConvertible: TypeAlias = Union[Tuple[Union[ExpressionT, str], ...],
ExpressionT, type[auto], str, tuple[str, ...]] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #27
Firedrake CI run: firedrakeproject/firedrake#3851