-
Notifications
You must be signed in to change notification settings - Fork 1
PCBase base class for python type preconditioners
#25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjward
requested changes
Nov 7, 2025
JHopeCollins
commented
Nov 7, 2025
JHopeCollins
commented
Nov 7, 2025
connorjward
requested changes
Nov 7, 2025
Co-authored-by: Connor Ward <c.ward20@imperial.ac.uk>
pbrubeck
approved these changes
Nov 7, 2025
pbrubeck
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
connorjward
previously requested changes
Nov 7, 2025
Collaborator
connorjward
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise very happy. This is great.
JHopeCollins
commented
Nov 7, 2025
connorjward
approved these changes
Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumped up from https://github.com/firedrakeproject/firedrake/blob/main/firedrake/preconditioners/base.py, although this doesn't implement all of the methods in the Firedrake class because some of those need firedrake specific things (e.g. forms, or how we deal with the appctx).
The important two things are:
setUpto call initialise only on the first call. This just saves either duplicating work unnecessarily or having a really chunky if-block insetUp.abstractmethodfor the minimal interface ofinitialize,update, andapply.