Conversation
| end | ||
|
|
||
| describe "/colorize" do | ||
| it "has a button named 'Colorize'", points: 1 do |
There was a problem hiding this comment.
What do you think about "has a 'Colorize' button"? Do you think there's any danger of "named 'Colorize'" making some students wonder if they should add a name="" attribute to the <button>?
spec/features/algorithmia_spec.rb
Outdated
| describe "/colorize" do | ||
| it "displays the colorized image", points: 5 do | ||
| #==================== Begin setup ===========================# | ||
| # create fake Algorithmia objects to speed up tests |
There was a problem hiding this comment.
Perhaps if there's bespoke/non-generally applicable setup that we don't intend the students to read/familiarize themselves with, we should think about extracting it to a well-named method?
There was a problem hiding this comment.
Something in rails_helper perhaps?
There was a problem hiding this comment.
Maybe, or maybe just a method at the bottom of the same file so we can easily direct curious students to it?
There was a problem hiding this comment.
Was able to move most of the code to methods, but the class double is still causing errors. Needed to leave that in.
2 participants
Can you run through the two problems and see if you come across any issues?