Feat/ahp #18

hello-sahasraka · 2025-11-07T09:30:23Z

No description provided.

…stency ratio

Copilot

Pull request overview

This PR adds AHP (Analytic Hierarchy Process) functionality to the application, implementing a multi-criteria decision analysis tool that can compute weighted rankings of alternatives based on criteria comparisons.

Changes:

Added mathjs library dependency for matrix operations
Implemented AHP computation utilities including matrix validation, priority vector calculation, and consistency ratio computation
Created API endpoint /api/v1/ahp for data-driven AHP calculations

Reviewed changes

Copilot reviewed 9 out of 11 changed files in this pull request and generated 13 comments.

Show a summary per file

File	Description
src/utils/validateMatrix.js	Matrix validation for reciprocal matrices used in AHP
src/utils/pairwiseMatrix.js	Builds pairwise comparison matrices from raw data
src/utils/computePriorityVector.js	Computes priority vectors using geometric mean method
src/utils/computeConsistancyRatio.js	Calculates consistency ratio for pairwise matrices
src/utils/ahs.js	Core AHP computation logic
src/controllers/ahpController.js	HTTP controller for AHP endpoint
src/routes/ahpRoutes.js	Express router for AHP routes
server.js	Registers AHP routes in the application
package.json	Adds mathjs dependency
package-lock.json	Lock file updates for mathjs and its dependencies

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-15T14:15:40Z

src/utils/computeConsistancyRatio.js

+import { create, all } from "mathjs";
+
+const math = create(all, {});


The mathjs instance is created but never used in this file. The math.multiply function is called on line 14, but since mathjs is imported and configured, you should verify if this configuration is necessary. If the multiply function works without the custom math instance, consider removing the unused constant.

Copilot · 2026-01-15T14:15:41Z

src/utils/ahs.js

+import { create, all } from "mathjs";
+import matrixValidation from "./validateMatrix.js";
+import weightVectorGeometricMean from "./computePriorityVector.js";
+import { consistencyRatio } from "./computeConsistancyRatio.js";
+
+const math = create(all, {});
+


The mathjs instance is created but never used in this file. Since no mathjs operations are performed directly in this module, consider removing this unused import and constant.

Suggested change

import { create, all } from "mathjs";

import matrixValidation from "./validateMatrix.js";

import weightVectorGeometricMean from "./computePriorityVector.js";

import { consistencyRatio } from "./computeConsistancyRatio.js";

const math = create(all, {});

import matrixValidation from "./validateMatrix.js";

import weightVectorGeometricMean from "./computePriorityVector.js";

import { consistencyRatio } from "./computeConsistancyRatio.js";

Copilot · 2026-01-15T14:15:41Z

src/utils/validateMatrix.js

+    console.log("Validating matrix:", matrix);
+


Debug console.log statement should be removed from production code. This could log potentially large matrices and cause performance issues. If logging is needed, consider using a proper logging library with configurable log levels.

Suggested change

console.log("Validating matrix:", matrix);

Copilot · 2026-01-15T14:15:42Z

src/utils/pairwiseMatrix.js

+  // debug: log matrix shapes (removed after diagnosing issues)
+  try {
+    // avoid large dumps; log dimensions and a sample
+    const altKeys = Object.keys(alternativeMatrices);
+    const altShapes = altKeys.map(k => ({ key: k, size: alternativeMatrices[k]?.length ?? 0 }));
+    console.log('computeDataDrivenAHP: criteriaMatrix size=', criteriaMatrix.length, 'alternativeMatrices=', altShapes);
+  } catch (e) {
+    console.error('computeDataDrivenAHP debug error', e);
+  }
+
+


Debug console.log statement should be removed from production code. The comment on line 51 mentions 'removed after diagnosing issues' but the log is still present. Consider using a proper logging library with configurable log levels or remove this debug code.

Suggested change

// debug: log matrix shapes (removed after diagnosing issues)

try {

// avoid large dumps; log dimensions and a sample

const altKeys = Object.keys(alternativeMatrices);

const altShapes = altKeys.map(k => ({ key: k, size: alternativeMatrices[k]?.length ?? 0 }));

console.log('computeDataDrivenAHP: criteriaMatrix size=', criteriaMatrix.length, 'alternativeMatrices=', altShapes);

} catch (e) {

console.error('computeDataDrivenAHP debug error', e);

}

Copilot · 2026-01-15T14:15:42Z

src/controllers/ahpController.js

+  }
+
+  try {
+    console.log("Start running AHP computation");


Debug console.log statement should be removed from production code. Consider using a proper logging library consistent with the rest of the application, or remove this debug statement.

Suggested change

console.log("Start running AHP computation");

Copilot · 2026-01-15T14:15:44Z

src/controllers/ahpController.js

+  const { criteriaNames, alternativeNames, dataMatrix, benefitFlags } = req.body || {};
+
+  if (!req.body) {
+    return res.status(400).json({ error: 'Request body is required. Please send JSON with dataMatrix, criteriaNames, alternativeNames, and benefitFlags.' });
+  }
+


The check on line 6 is redundant since req.body is already accessed on line 4 with a fallback to an empty object. If req.body is null/undefined, the destructuring on line 4 will use {} and the variables will be undefined. The check should be moved before the destructuring, or specific parameter validation should be added instead.

Suggested change

const { criteriaNames, alternativeNames, dataMatrix, benefitFlags } = req.body || {};

if (!req.body) {

return res.status(400).json({ error: 'Request body is required. Please send JSON with dataMatrix, criteriaNames, alternativeNames, and benefitFlags.' });

}

const body = req.body;

if (!body || typeof body !== 'object') {

return res.status(400).json({ error: 'Request body is required. Please send JSON with dataMatrix, criteriaNames, alternativeNames, and benefitFlags.' });

}

const { criteriaNames, alternativeNames, dataMatrix, benefitFlags } = body;

Copilot · 2026-01-15T14:15:44Z

src/controllers/ahpController.js

+  if (!Array.isArray(dataMatrix)) {
+    return res.status(400).json({ error: 'dataMatrix must be an array.' });
+  }
+


Incomplete input validation. The controller only validates that dataMatrix is an array but doesn't validate other required parameters (criteriaNames, alternativeNames). These are required by computeDataDrivenAHP and will cause unclear error messages if missing. Add validation for all required parameters.

Suggested change

if (!Array.isArray(criteriaNames) || criteriaNames.length === 0) {

return res.status(400).json({ error: 'criteriaNames must be a non-empty array.' });

}

if (!Array.isArray(alternativeNames) || alternativeNames.length === 0) {

return res.status(400).json({ error: 'alternativeNames must be a non-empty array.' });

}

Copilot · 2026-01-15T14:15:45Z

src/utils/computeConsistancyRatio.js

@@ -0,0 +1,30 @@
+import { create, all } from "mathjs";


Filename has a typo: 'Consistancy' should be 'Consistency'. The file is named 'computeConsistancyRatio.js' but should be 'computeConsistencyRatio.js'.

Copilot · 2026-01-15T14:15:45Z

src/controllers/ahpController.js

@@ -0,0 +1,28 @@
+import { computeDataDrivenAHP } from "../utils/pairwiseMatrix.js";
+
+export const dataDrivenAHP = (req, res) => {


The new AHP controller lacks test coverage. All other controllers in the codebase (branchController, messageController, thirdPartiesController, etc.) have corresponding test files in src/tests/. Consider adding comprehensive tests for the AHP controller covering successful computation, validation errors, and error handling.

Copilot · 2026-01-15T14:15:46Z

src/routes/ahpRoutes.js

+import express from 'express';
+import { dataDrivenAHP } from '../controllers/ahpController.js';
+
+const router = express.Router();


Import style is inconsistent with other route files in the codebase. Other route files use destructured imports like import { Router } from 'express' (see branch.js line 2). Consider using the same pattern for consistency.

Suggested change

import express from 'express';

import { dataDrivenAHP } from '../controllers/ahpController.js';

const router = express.Router();

import { Router } from 'express';

import { dataDrivenAHP } from '../controllers/ahpController.js';

const router = Router();

vindyakodithuwakku02

CI fixed and checks passed.

hello-sahasraka added 3 commits November 7, 2025 10:58

feat(ahp): implement data-driven AHP computation and routing

2154c05

feat(ahs): implement AHP computation with matrix validation and consi…

c3c9966

…stency ratio

feat(ahp): add AHP routing and integrate mathjs dependency

416635d

hello-sahasraka requested review from Mariettrodrigo, kavindalj, naveensanjula975, pabasara20 and vindyakodithuwakku02 November 7, 2025 09:30

Merge branch 'dev' into feat/ahp

a8a943a

Copilot AI review requested due to automatic review settings January 15, 2026 14:11

Copilot started reviewing on behalf of vindyakodithuwakku02 January 15, 2026 14:12 View session

vindyakodithuwakku02 previously approved these changes Jan 15, 2026

View reviewed changes

Copilot AI reviewed Jan 15, 2026

View reviewed changes

chore: fix npm audit vulnerability

035d508

vindyakodithuwakku02 dismissed their stale review via 035d508 January 15, 2026 14:47

vindyakodithuwakku02 approved these changes Jan 15, 2026

View reviewed changes

vindyakodithuwakku02 merged commit 589e7fe into dev Jan 15, 2026
6 checks passed

vindyakodithuwakku02 deleted the feat/ahp branch January 15, 2026 15:16

		import { create, all } from "mathjs";

		const math = create(all, {});

+  if (!Array.isArray(criteriaNames) || criteriaNames.length === 0) {
+    return res.status(400).json({ error: 'criteriaNames must be a non-empty array.' });
+  }
+  if (!Array.isArray(alternativeNames) || alternativeNames.length === 0) {
+    return res.status(400).json({ error: 'alternativeNames must be a non-empty array.' });
+  }

		@@ -0,0 +1,28 @@
		import { computeDataDrivenAHP } from "../utils/pairwiseMatrix.js";

		export const dataDrivenAHP = (req, res) => {

Feat/ahp #18

Feat/ahp #18

Uh oh!

Conversation

hello-sahasraka commented Nov 7, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

vindyakodithuwakku02 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants