Sync upstream to paint worklet #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added void functions and declaration statement for module export
Updates to TypeScript definitions
Adobe changed the preferences - updated the path to match the new path
Updated preferences path in 'After installation'
scaleMode appears to be deprecated (didn't do anything and is missing in the TypeScript types). https://stackoverflow.com/questions/53938016/lottie-and-scalemode-settings-for-the-web says preserveAspectRatio replaced it, and this change updates the docs to use that instead.
Fix aria-label name typo
Replace scaleMode with preserveAspectRatio in README
… of a shape modifier
type AnimationEventName has been extended with 'destroy' | 'config_ready' | 'data_ready' | 'DOMLoaded' events.
Extend AnimationEventName type
Add missing isLoaded property in type definitions.
…alues have been modified
Add missing initialSegment property in type declarations
This declaration was missing even though filterSize is a valid property and used throughout the library.
Add filterSize declaration to AnimationConfig
Collaborator
Author
|
current runtime error: |
Collaborator
Author
|
enough conflicts here that I need some help. it looks like they made changes to provide better ways for workers to integrate, essentially stomping on some of the integration work done by @flackr. i assume the errors i'm seeing are things that Robert already overcame and knows where the changes need to go? if y'all disagree with updating to latest lottie before making the PR, we can close and delete my branch. let me know! |
Collaborator
Author
|
there's a bunch of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it's not perfect, the es_module needs an update. i am able to get passed it tho for testing, and then i get another error
lottiejs.loadAnimation is not a function at Object.paint. i feel like it'd behoove us to sync with master before pitching the PR? i feel like this is close. i'm uploading just to show progress, but i'll attack it again soon. open to input and advice as well!