Skip to content

Fix Non-Idempotent-Outcome flaky test: test_cmd_path #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zhihao11ui wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix Non-Idempotent-Outcome flaky test: test_cmd_path #22

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions tests/test_system.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,13 +352,17 @@ def test_dir_cmd(self, mycmd):
assert which(mycmd) == mycmd

def test_cmd_path(self, tmpdir, mycmd):
path = str(tmpdir)
assert which('mycmd') is None
assert which('mycmd', path=path) == mycmd

os.environ['PATH'] = path + os.pathsep + \
os.environ.get('PATH', os.defpath)
assert which('mycmd') == mycmd
original_path = os.environ['PATH']
try:
path = str(tmpdir)
assert which('mycmd') is None
assert which('mycmd', path=path) == mycmd

os.environ['PATH'] = path + os.pathsep + \
os.environ.get('PATH', os.defpath)
assert which('mycmd') == mycmd
finally:
os.environ['PATH'] = original_path


@pytest.mark.skipif(not WINDOWS, reason='Not support non Windows')
Expand Down