Conversation
Details: - Added .c_next field to auxinfo_t struct definition. - Defined accessor macros for the auxinfo_t.c_next field. - Compute reasonable values for c_next within the gemm macrokernel (bli_gemm_ker_var2.c) and embed them within the local auxinfo_t that is passed along into the gemm microkernel. Thanks to Devin Matthews and AMD for their contributions toward this feature.
Member
Author
|
Note to self: Credit LeickR in the final squashed commit log. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch contains preliminary support for a new
.c_nextfield within theauxinfo_tstruct. It is fully implemented forgemm. Caveats:gemmmacrokernel (bli_gemm_ker_var2()) sets the.c_nextfield. Thegemmt,trmm, andtrsmmacrokernels are (for now) oblivious.(h/t to @devinamatthews and AMD for their contributions to this feature)
Note: I think we should wait until some of @devinamatthews's pending changes (which impact the non-
gemmmacrokernels) are merged before we extend this to the other level-3 operations. (I'm referring specifically to de-macroification.)