feat: add chain-monitor
#225
Conversation
julio4
force-pushed
the
feat/chain-monitor
branch
from
ae11b20 to
fa1ed4c
Compare
playground/recipe_opstack.go
Outdated
| }) | ||
|
|
||
| svcManager.MustGetService("chain-monitor"). | ||
| DependsOnHealthy("el"). |
There was a problem hiding this comment.
Why don't you define this DependsOnHealthy on the component?
ferranbt
left a comment
ferranbt
left a comment
There was a problem hiding this comment.
Looks good - just a few questions.
julio4
force-pushed
the
feat/chain-monitor
branch
from
fa1ed4c to
1356606
Compare
playground/recipe_opstack.go
Outdated
|
|
||
| svcManager.AddService(&ChainMonitor{ | ||
| L1RPC: "el", | ||
| L2BlockTime: l2BlockTime, |
There was a problem hiding this comment.
Why not pass the int directly and convert to string in the component?
ferranbt
left a comment
ferranbt
left a comment
There was a problem hiding this comment.
LGTM! One final comment though. Normally, the health checks are used for services that stop right away if the other service is not available. Does that happen for chain monitor? Or it would just start anyway and connect once the other services ara available?
Yeah clearly not sure if it's the best way but when launching chain-monitor if the metric ports of targeted services are not available it shutdown. Is there a better way to wait? |
# Conflicts: # playground/components.go # Conflicts: # playground/catalog.go # Conflicts: # playground/catalog.go
julio4
force-pushed
the
feat/chain-monitor
branch
from
1356606 to
bceec6b
Compare
julio4
force-pushed
the
feat/chain-monitor
branch
from
bceec6b to
c5c730a
Compare
2 participants
Add new
--chain-monitorflag for opstack recipe to bootstrap https://github.com/flashbots/chain-monitorUsing
0xf39Fd6e51aad88F6F4ce6aB8827279cffFb92266as builder signer for op-rbuilder