Skip to content

coreos-base/coreos-init: drop daemon-reload command #1937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
tormath1 wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

coreos-base/coreos-init: drop daemon-reload command #1937

tormath1 wants to merge 2 commits into from

Conversation

@tormath1
Copy link
Contributor

@tormath1 tormath1 commented Apr 18, 2024

With the recent systemd upgrade we do not need to reload the systemd daemon anymore.

This pulls:

@tormath1
coreos-base/coreos-init: drop daemon-reload command
7256148 
With the recent systemd upgrade we do not need to reload the systemd
daemon anymore

Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
@tormath1 tormath1 added the main label Apr 18, 2024
@tormath1 tormath1 self-assigned this Apr 18, 2024
pothos
pothos reviewed Apr 18, 2024
View reviewed changes
Copy link
Member

@pothos pothos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I read it correctly, in sdk_container/src/third_party/coreos-overlay/coreos/config/env/sys-apps/systemd we could use After=systemd-sysext.service instead of After=ensure-sysext.service

@tormath1
build_sysext: teach sysext to reload the daemon
0ff5ec6 
This ensures that the Systemd daemon is reloaded once the sysext image merged.

Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
@pothos
Copy link
Member

pothos commented Apr 18, 2024 •
edited
Loading

Some more problems, even if the Flatcar extensions would set EXTENSION_RELOAD_MANAGER they still need to use .upholds/ symlinks instead of .wants.

ZFS: multi-user.target.wants/zfs.target → multi-user.target.upholds/zfs.target
Containerd: multi-user.target.wants/containerd.service
AWS: multi-user.target.wants/ntpd.service
Azure: multi-user.target.wants/chronyd.service
GCE: multi-user.target.wants/ntpd.service

One way is to patch WantedBy= to be UpheldBy and then the enablement with systemctl enable would work.

@github-actions
Copy link

github-actions bot commented Apr 18, 2024

Build action triggered: https://github.com/flatcar/scripts/actions/runs/8738383351

@github-actions github-actions bot mentioned this pull request Apr 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pothos pothos pothos left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@tormath1 tormath1

Labels

main

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tormath1 @pothos