postinst: Make sure Flatcar extension folder exists #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tormath1
reviewed
Sep 3, 2025
Contributor
tormath1
left a comment
tormath1
left a comment
There was a problem hiding this comment.
LGTM. Only the sign-off mention is missing!
When a Flatcar extension file is created on an old node that doesn't yet support them but the update will, and already downloads it, then we also need to create the folder because it's not existing yet. Fixes flatcar/Flatcar#1788 Signed-off-by: Kai Lueke <kailuke@microsoft.com>
pothos
force-pushed
the
kai/corner-case
branch
from
a44fb94 to
9b5ab35
Compare
pothos
added a commit
to flatcar/scripts
that referenced
this pull request
Sep 3, 2025
This pulls in flatcar/update_engine#50 to fix a corner case when the extension file exists on old nodes that don't yet support extensions but should pull them on their update. Signed-off-by: Kai Lueke <kailuke@microsoft.com>
2 tasks
Member
Author
|
Tested and solves the issue |
tormath1
approved these changes
Sep 3, 2025
pothos
added a commit
to flatcar/scripts
that referenced
this pull request
Sep 3, 2025
This pulls in flatcar/update_engine#50 to fix a corner case when the extension file exists on old nodes that don't yet support extensions but should pull them on their update. Signed-off-by: Kai Lueke <kailuke@microsoft.com>
pothos
added a commit
to flatcar/scripts
that referenced
this pull request
Sep 4, 2025
This pulls in flatcar/update_engine#50 to fix a corner case when the extension file exists on old nodes that don't yet support extensions but should pull them on their update. Signed-off-by: Kai Lueke <kailuke@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a Flatcar extension file is created on an old node that doesn't yet support them but the update will, and already downloads it, then we also need to create the folder because it's not existing yet.
Fixes flatcar/Flatcar#1788
How to use
Testing done
Tested with
./flatcar-update -V 9999.9.9 -P flatcar_test_update.gz -E flatcar_test_update-flatcar-python.gz -D -Awhen updating from LTS 3033.3.18 with/etc/flatcar/enabled-sysext.confcontainingpythonchangelog/directory (user-facing change, bug fix, security fix, update)/bootand/usrsize, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.