Add two-pass approach to match AST#12
Open
Thoemi09 wants to merge 3 commits intoflatironinstitute:unstablefrom
Open
Add two-pass approach to match AST#12Thoemi09 wants to merge 3 commits intoflatironinstitute:unstablefrom
Thoemi09 wants to merge 3 commits intoflatironinstitute:unstablefrom
Conversation
Contributor
Thoemi09
commented
Dec 12, 2025
Thoemi09
commented
- first match classes/enums to detect all wrapped types
- then match functions which may rely on wrapped types
- first match classes/enums to detect all wrapped types - then match functions which may rely on wrapped types
Minor cleaning
Collaborator
|
Can you add a non regression test for this in basicfun or in tpl_something ? |
Contributor
Author
|
Sure, I have made the following PR: flatironinstitute/c2py#9 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.