Preserve constness of built-in types in gfqn_impl1#9
Open
Thoemi09 wants to merge 3 commits intoflatironinstitute:unstablefrom
Open
Preserve constness of built-in types in gfqn_impl1#9Thoemi09 wants to merge 3 commits intoflatironinstitute:unstablefrom
Thoemi09 wants to merge 3 commits intoflatironinstitute:unstablefrom
Conversation
Thoemi09
force-pushed
the
fullqualifiedname
branch
from
47a5b79 to
2247bb0
Compare
- desugar type alias templates (like get_value_t<...>) to their underlying canonical types instead of preserving the unresolved alias name, e.g. nda::basic_array<nda::get_value_t<nda::expr<'*', std::complex<double>, const nda::basic_array<std::complex<double>, 2, nda::C_layout, 'M', nda::heap_basic<nda::mem::mallocator<nda::mem::AddressSpace::Host>>> &>>,2,nda::C_layout,77,nda::heap<1>> becomes nda::basic_array<std::complex<double>, 2, nda::C_layout, 77, nda::heap_basic<nda::mem::mallocator<nda::mem::AddressSpace::Host>>>
- char template arguments are preserved as charater literals instead of their numeric value
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.