Rework the setAdminSettings and Ajust log level #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 6, 2021 12:15
This rework fixes the error bellow: Error: array_filter() expects parameter 1 to be array, null given at /var/www/nextcloud/apps/roundcube/lib/Controller/SettingsController.php#149 This error log happens when the admin tries to save the config without setting the 'Per email domain RC installations'. Signed-off-by: Igor Matheus Andrade Torrente <igormtorrente@gmail.com>
If the admin doesn't configure the 'Per email domain installation', a log was emittied every time that someone logged into the Roundcube. This is annoying and unnecessary. I adjusted the log to not be visible unless under a more sensible log level. Signed-off-by: Igor Matheus Andrade Torrente <igormtorrente@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.