Add helpers for deployments without roles#43
Open
BattleBrisket wants to merge 3 commits intoflogic:masterfrom
Open
Add helpers for deployments without roles#43BattleBrisket wants to merge 3 commits intoflogic:masterfrom
BattleBrisket wants to merge 3 commits intoflogic:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No matter how my deployment roles lay out for production and staging, I always have one or two environments (development, and occasionally a demo server) that put all the roles on a single instance. In those cases, roles are effectively meaningless.
Initially I would handle those situations by writing conditionals in my rake tasks that look like this...
...but that exposes WhiskeyDisk internals within my rake tasks. The conditionals also get a bit uglier when trying to watch for interesting file changes...
So I added some helpers that encapsulate the notion, "Is this a deployment without any roles at all?"
no_roles?returns true if theENV['WD_ROLES']definition is empty.nothing_or_role?(role)returns true if the current deployment has the specified role, or if theENV['WD_ROLES']definition is empty.