Open
Conversation
When determining a cache key and stating that the ttl for the query should be now until for instance the end of day. We have a little tiny but in that the sha1 key will ALWAYS be different sense ttl value is stored along side the cache key. Use to the serialization of the object. This pr fixes that.
Owner
|
@morloderex Thanks for your PR :) I would maybe instead introduce a |
Author
|
@florianv thanks for your feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When determining a cache key and stating that the ttl for the query should be now until for instance the end of day. We have a little tiny bug in that the sha1 key will ALWAYS be different sense ttl value is stored alongside the cache key. Use to the serialization of the object.
This pr fixes that by being more explicit about how the sha1 value is created now instead of serializing the whole exchangeQuery object we take out the specific parameters which we know are constants.
E.g the base and counter currency and for historical fetches we also take out the date in
Y-m-dformat