Port to Python 3 and harden unsafe input handling#9
Open
Am1rTl wants to merge 1 commit intoflosch:masterfrom
Open
Port to Python 3 and harden unsafe input handling#9Am1rTl wants to merge 1 commit intoflosch:masterfrom
Am1rTl wants to merge 1 commit intoflosch:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR modernizes
simpleapifor Python 3 and hardens insecure request/serialization paths.What changed
Python 3 modernization
python_requires >= 3.9setup.pyfile handling.inspect.getargspecfallback viagetfullargspec.cgiparsing in standalone handler.Security hardening
picklein__input__, it is filtered out unless explicitly opted-in.__allow_unsafe_pickle_input__ = True(or legacy alias__allow_unsafe_pickle__).__authentication__._mimetypeoverride is blocked by default_mimetypenow rejected unless route is created withallow_custom_mimetype=True.defusedxml.ElementTreewhen available.Tests
tests/test_security.pycovering:_mimetypeoverride blocking;Verification
Backward compatibility notes
_input=pickleis no longer accepted unless explicitly enabled._mimetyperequest override is no longer accepted unless explicitly enabled.