Skip to content

Update edd-software-license-manager.php#8

Open
btwatts wants to merge 2 commits intoflowdee:masterfrom
btwatts:master
Open

Update edd-software-license-manager.php#8
btwatts wants to merge 2 commits intoflowdee:masterfrom
btwatts:master

Conversation

@btwatts
Copy link

@btwatts btwatts commented May 6, 2016

This is part 1 of 3 changes required to add License Term as a 'global' setting in edd-software-license-manager.

Apparently I did the wrong the first time because I can't find the first change I made to this file.

This is my first GitHub change...so I might probably have done something incorrectly.

Please forgive my ignorance.

btwatts added 2 commits May 5, 2016 23:53
This is part 1 of 3 changes required to add License Term as a 'global' setting in edd-software-license-manager.

Apparently I did the wrong the first time because I can't find the first change I made to this file.

This is my first GitHub change...so I might probably have done something incorrectly.

Please forgive my ignorance.
It might be argued that there could and possibly should be more filters than this one.

It turns out that the other settings are acceptable to me when the prior pull requests are also applied.

The problem I'm trying to solve is the ability to associate a specific product to a specific license key.

The mechanism as it stands does not make this process easy.

However, with the filter in place, the user of the edd_slm plugin can specify the transaction ID as needed to connect the license to the product more closely.
@btwatts
Copy link
Author

btwatts commented May 9, 2016

I fear I'm not an expert in github still.

Please let me know what I need to do to help get these changes into an updated plugin.

@flowdee
Copy link
Owner

flowdee commented May 9, 2016

Hey @btwatts, it's fine so far, thanks for your help! I'll take a look into as soon as I find time and update the plugin

@btwatts
Copy link
Author

btwatts commented May 9, 2016

I did several pulls that maybe could be only one pull.

Thanks for taking a look.
On May 9, 2016 10:08 AM, "flowdee" notifications@github.com wrote:

Hey @btwatts https://github.com/btwatts, it's fine so far, thanks for
your help! I'll take a look into as soon as I find time and update the
plugin


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#8 (comment)

@btwatts
Copy link
Author

btwatts commented May 18, 2016

I discovered a problem in my further testing that I believe is caused by my test for the existence of
'Easy Digital Downloads'

It appears that that early exit is causing the Extension Settings to break.

It is also possible that it is causing the entire plugin to exit in some cases that should not.

Please Verify Receipt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants