modify: add workaround for vote timer glitch

[fltuna]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @fltuna, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a 'vote timer glitch' by introducing a workaround that ensures a next map is automatically selected under specific conditions where the vote timer might fail to initiate properly, particularly when the server is empty or has insufficient time/rounds remaining. The changes also include refactoring of the vote timer creation logic for better organization and the addition of a comprehensive utility for random map selection.

Highlights

• Vote Timer Glitch Workaround: Implemented a new logic block in OnClientPutInServer to automatically select a random next map if the current timelimit or round count is too low for a vote to start and no players are currently on the server. This prevents potential map cycle stalls due to the 'vote timer glitch'.
• Centralized Vote Timer Condition Check: Refactored the RecreateVoteTimer and CreateVoteStartTimer methods to centralize the logic for determining if a vote timer should continue. This logic is now encapsulated within a new GetCorrespondTimelimitCheck method, improving maintainability.
• Random Map Selection Utility: Introduced a new private utility method, PickRandomMapForNextMap, which provides a robust way to select a random map based on various filtering criteria such as disabled status, cooldowns, player count restrictions, permissions, and allowed time ranges. This method is utilized by the new workaround logic.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a workaround for a vote timer glitch by picking a random next map when the first player joins and there's not enough time for a vote. The changes include refactoring the vote timer creation logic and adding a new method to pick a random map. My review focuses on a logic bug in the new workaround, significant code duplication, potential runtime exceptions, performance inefficiencies in the new map picking method, and some minor typos.