Fix: Correct image size calculation for macOS with NSImage#316
Merged
CaiJingLong merged 2 commits intofluttercandies:mainfrom Jan 2, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue where
NSImagewas returning incorrect image sizes on macOS.Issue
minWidthorminHeightvalues.NSImage.sizemethod returns size information that is screen resolution dependent.minHeightvalue of 1000, the resulting image size is 460 x 288, which is incorrect. This issue was observed on a Mac Mini connected to an LG monitor. It is unclear whether the same problem occurs with an iMac or an Apple external display.Details
NSImage.sizemethod withNSImageRep.pixelsWideandNSImageRep.pixelsHighto get the actual image size.Testing