Skip to content

Use task resources of 0 for sandbox #3541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wild-endeavor wants to merge 3 commits into from
Closed

Use task resources of 0 for sandbox #3541

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6fc7fb6
add defaults of 0
wild-endeavor Mar 27, 2023
1fc4125
make -C docker/sandbox-bundled manifests
wild-endeavor Mar 30, 2023
236487a
make helm
wild-endeavor Mar 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions charts/flyte-sandbox/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,11 @@ A Helm chart for the Flyte local sandbox
| flyte-binary.configuration.inline.plugins.k8s.default-env-vars[1].FLYTE_AWS_ACCESS_KEY_ID | string | `"minio"` | |
| flyte-binary.configuration.inline.plugins.k8s.default-env-vars[2].FLYTE_AWS_SECRET_ACCESS_KEY | string | `"miniostorage"` | |
| flyte-binary.configuration.inline.storage.signedURL.stowConfigOverride.endpoint | string | `"http://localhost:30002"` | |
| flyte-binary.configuration.inline.task_resources.defaults.cpu | string | `"0"` | |
| flyte-binary.configuration.inline.task_resources.defaults.memory | string | `"0"` | |
| flyte-binary.configuration.inline.task_resources.limits.cpu | string | `"0"` | |
| flyte-binary.configuration.inline.task_resources.limits.gpu | string | `"0"` | |
| flyte-binary.configuration.inline.task_resources.limits.memory | string | `"0"` | |
| flyte-binary.configuration.inlineConfigMap | string | `"{{ include \"flyte-sandbox.configuration.inlineConfigMap\" . }}"` | |
| flyte-binary.configuration.logging.level | int | `6` | |
| flyte-binary.configuration.logging.plugins.kubernetes.enabled | bool | `true` | |
Expand Down
8 changes: 8 additions & 0 deletions charts/flyte-sandbox/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,14 @@ flyte-binary:
templateUri: |-
http://localhost:30080/kubernetes-dashboard/#/log/{{.namespace }}/{{ .podName }}/pod?namespace={{ .namespace }}
inline:
task_resources:
defaults:
cpu: "0"
memory: "0"
limits:
cpu: "0"
gpu: "0"
memory: "0"
storage:
signedURL:
stowConfigOverride:
Expand Down
14 changes: 11 additions & 3 deletions docker/sandbox-bundled/manifests/complete.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -487,6 +487,14 @@ data:
signedURL:
stowConfigOverride:
endpoint: http://localhost:30002
task_resources:
defaults:
cpu: "0"
memory: "0"
limits:
cpu: "0"
gpu: "0"
memory: "0"
kind: ConfigMap
metadata:
labels:
Expand Down Expand Up @@ -765,7 +773,7 @@ type: Opaque
---
apiVersion: v1
data:
haSharedSecret: VnBOU0tUSU41Q2xCcnlQeA==
haSharedSecret: d0JFVmRTazdJOVhiQ1VQRw==
proxyPassword: ""
proxyUsername: ""
kind: Secret
Expand Down Expand Up @@ -1141,7 +1149,7 @@ spec:
metadata:
annotations:
checksum/cluster-resource-templates: 6fd9b172465e3089fcc59f738b92b8dc4d8939360c19de8ee65f68b0e7422035
checksum/configuration: cb6d3e1eda0d2913ad4a594e28137dd790892054856f74583344f7abaf00a11d
checksum/configuration: 812a428633d9c83340ee4afc9eefda37a641e6e2337cc6a1265258c9d23f4324
checksum/db-password-secret: 669e1cdf4633c6dd40085f78d1bb6b9672d8120ff1f62077a879a4d46db133e2
labels:
app.kubernetes.io/instance: flyte-sandbox
Expand Down Expand Up @@ -1249,7 +1257,7 @@ spec:
metadata:
annotations:
checksum/config: 8f50e768255a87f078ba8b9879a0c174c3e045ffb46ac8723d2eedbe293c8d81
checksum/secret: 91c457e16b511b53b62ae35de8ee25922d4f6bdd9314080917d35a4371913dfe
checksum/secret: 86d4297bed78971e06091f86bacbf4529b7dce6b6683f945557f420ddeb2b35e
labels:
app: docker-registry
release: flyte-sandbox
Expand Down
4 changes: 2 additions & 2 deletions docker/sandbox-bundled/manifests/dev.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -499,7 +499,7 @@ metadata:
---
apiVersion: v1
data:
haSharedSecret: VVEybHJXNFB1dG1MOGFHMw==
haSharedSecret: QTVMS1ZLblR6bjdGeVFoSg==
proxyPassword: ""
proxyUsername: ""
kind: Secret
Expand Down Expand Up @@ -875,7 +875,7 @@ spec:
metadata:
annotations:
checksum/config: 8f50e768255a87f078ba8b9879a0c174c3e045ffb46ac8723d2eedbe293c8d81
checksum/secret: c6c04852c5465cb16c65eece01dad679035d630a275fe214868372580cbfffc3
checksum/secret: 3905a0dc15d9c88afd623143d35a233937174040ac0d542be387fe67847fe0ac
labels:
app: docker-registry
release: flyte-sandbox
Expand Down