Dev to master, with regions and spatial indexing. #387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…an be accessed from the original vlsv file that has a linked sidecar file
…nd fix a small docstring typo
… of yt, remove unnecessary imports and function
… takes a vlsvfile name and keyword arguments and returns magnetopause as triangle mesh vertices and faces (3d) or array (2d). Remove unnecessary functions, change units from RE to m.
…or streamline seeds.
…ing function from calculations
…y) fix import issues
missing endline
Cache files framework, spatial indexing for SpatialGrid reads. Also includes file-caching infra for AMR neighborhood stencils (via pickle[!], to be anyway redone for performance, and this currently needs to be driven via an external script). There definitely are things to consolidate further, but to get the performance benefits available this goes to dev now. Propagation to master branch is pending testpackage implementation, at least.
Region classification - into dev as well, these prototypes are already useful!
Cache files amendment
Bring dev up to date with master
Updating dev to master
alhom
commented
Dec 15, 2025
| bboxes = self.__reader.get_mesh_domain_extents("SpatialGrid") | ||
| bboxes = bboxes.reshape((-1,6), order='C') | ||
|
|
||
| self.__rtree_index = rtree.index.Index(self.__rtree_idxfile[:-4],properties=self.__rtree_properties, interleaved=False) |
Member
Author
There was a problem hiding this comment.
This will need a custom storage implementation/fix in the rtree package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... this will need a bit thought as dev had gotten a bit stale.