Have Entry::symlink() return Option<&str>#5
Open
17dec wants to merge 2 commits intofnichol:masterfrom
Open
Conversation
added 2 commits
October 16, 2016 12:41
libarchive may return NULL.
archive_entry_filetype() can return 0. It does this for hard links in a GNU tar-created archive.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
archive_entry_symlink()returns NULL if the entry is not a symlink. Calling Entry::symlink() would result in a segfault in that case.This PR introduces API breakage by changing the return type; A less breaking solution is to have the method panic on NULL, but that'd be inconsistent with other methods such as Entry::hardlink().