fix: disable button on sponsorship manage addon popup when deleted #732
+6
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where the "Save Changes" button in the manage addon popup remained enabled after deleting an addon, even though there were no actual changes to save. The issue occurred because the popup component was using a stale snapshot of the sponsorship data.
Changes:
- Refactored sponsorship selection from storing the entire sponsorship object to storing only the sponsorship ID
- The selected sponsorship is now derived from the current Redux state, ensuring the popup always receives the latest data
- This allows the form to properly reinitialize when addon deletions update the sponsorship in the store
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: https://app.clickup.com/t/86b7n66b5
Signed-off-by: Tomás Castillo tcastilloboireau@gmail.com