Skip to content
This repository was archived by the owner on Apr 26, 2025. It is now read-only.

Conversation

@KernelDeimos
Copy link
Contributor

@KernelDeimos KernelDeimos commented Nov 28, 2020

Adding DNM because I want to test a serializable sink solution.

@google-cla google-cla bot added the cla: yes label Nov 28, 2020
@KernelDeimos KernelDeimos changed the title [NP-2802] Make predicates ContextAware [DMN] [NP-2802] Make predicates ContextAware Nov 28, 2020
@KernelDeimos KernelDeimos changed the title [DMN] [NP-2802] Make predicates ContextAware [DNM] [NP-2802] Make predicates ContextAware Nov 28, 2020
@KernelDeimos KernelDeimos changed the title [DNM] [NP-2802] Make predicates ContextAware [NP-2802] Make predicates ContextAware Nov 28, 2020
@jlhughes jlhughes requested a review from kgrgreer November 28, 2020 20:05
@KernelDeimos KernelDeimos changed the title [NP-2802] Make predicates ContextAware [DNM] [NP-2802] Make predicates ContextAware Nov 29, 2020
@lchanmann
Copy link
Contributor

Discussed with Eric offline to try overriding 'deepClone' instead.

@KernelDeimos
Copy link
Contributor Author

The deepClone approach gives me the system context, but to check if preconditions are met the session context is needed. There is also a security concern with predicates accessing the system context.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants