This repository was archived by the owner on Apr 26, 2025. It is now read-only.
[NP-3464] File select - table view #4731
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mykola97
approved these changes
Feb 2, 2021
jlhughes
commented
Feb 7, 2021
| "serviceScript": """ | ||
| httpBlobService = new foam.nanos.blob.HttpBlobService(x, x.get("blobStore")); | ||
| return new foam.nanos.http.SessionWebAgent("service.run.httpBlobService", httpBlobService); | ||
| return new foam.nanos.blob.HttpBlobService(x, x.get("blobStore")); |
Contributor
Author
There was a problem hiding this comment.
@Mykola97 let's leave httpBlob and httpFileService requiring login/authentication, and use service/file for unauthenticated requests. So we'll revert these two changes.
* fix image show * remove listner form filePreview * Add comments to filePreview
* add sessionWebAgent to httpFileService and httpBlobService
jlhughes
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.