Merged
Conversation
Consolidates attached disk config logic in Compute::Google::Disk.get_as_boot_disk to reuse code from the collection Disks.attached_disk_obj method.
houndci-bot
reviewed
Dec 10, 2018
Codecov Report
@@ Coverage Diff @@
## master #435 +/- ##
==========================================
+ Coverage 84.94% 85.34% +0.39%
==========================================
Files 339 339
Lines 5825 5826 +1
==========================================
+ Hits 4948 4972 +24
+ Misses 877 854 -23
Continue to review full report at Codecov.
|
houndci-bot
reviewed
Jan 8, 2019
| assert(snapshot.is_a?(Fog::Compute::Google::Snapshot), | ||
| "Resulting snapshot should be a snapshot object.") | ||
|
|
||
| assert_raises(ArgumentError){ snapshot.set_labels(["bar","test"]) } |
There was a problem hiding this comment.
Layout/SpaceBeforeBlockBraces: Space missing to the left of {.
Style/WordArray: Use %w or %W for an array of words.
Layout/SpaceAfterComma: Space missing after comma.
icco
approved these changes
Jan 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Will close #425 in favor of this for JRuby fixes.
Otherwise - mainly docs + tests for attached disks behaviour, to avoid confusion like in #434.