MODINV-1321: Vert.x 4.5.23 fixing CVE-2025-67735 Netty CRLF injection #879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aliaksandr-Fedasiuk
approved these changes
Dec 17, 2025
https://folio-org.atlassian.net/browse/MODINV-1321 Fix Netty CRLF injection request smuggling * CVE-2025-67735 GHSA-84h7-rjj3-6jx4 Approach Bump Vertx from 4.5.13 to 4.5.23. This requires to also bump mod-source-record-storage-client from 5.10.0 to 5.10.14 to get a compatible RMB version, see https://github.com/folio-org/raml-module-builder/releases/tag/v35.4.2 In TenantApiTest#shouldNotDropSchemaWithIncorrectConnectionOptions we need an invalid port number because the new Vertx version makes longer lookup retries for the hostname `invalid` that exceeds our timeout of 10 seconds. The invalid port number immediately fails and speeds up the test.
julianladisch
force-pushed
the
MODINV-1321
branch
from
36e550b to
d03cb26
Compare
|
KaterynaSenchenko
approved these changes
Jan 13, 2026
Aliaksandr-Fedasiuk
approved these changes
Jan 13, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://folio-org.atlassian.net/browse/MODINV-1321
Fix Netty CRLF injection request smuggling
Approach
Bump Vertx from 4.5.13 to 4.5.23.
This requires to also bump mod-source-record-storage-client from
5.10.0 to 5.10.14 to get a compatible RMB version, see
https://github.com/folio-org/raml-module-builder/releases/tag/v35.4.2
In TenantApiTest#shouldNotDropSchemaWithIncorrectConnectionOptions we
need an invalid port number because the new Vertx version makes longer
lookup retries for the hostname
invalidthat exceeds our timeout of10 seconds. The invalid port number immediately fails and speeds up the
test.