Skip to content

Conversation

@JohnC-80
Copy link
Contributor

@JohnC-80 JohnC-80 commented Apr 2, 2024

A form library is used in the change due date dialog only to catch changes to the entire form state values. It isn't used for submission, and the navigation blocking is turned off in this case...

This PR removes stripes-form from changeDueDateDialog and just goes vanilla.

The props of DueDatePickerForm are adjusted so that it uses the initialValues prop and the onChange handler whereas previously, stripes-form was using those.

Conversion to a functional component comes standard with this PR.

@github-actions
Copy link

github-actions bot commented Apr 2, 2024

Jest Unit Test Statistics

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ±0 

Results for commit 81779b6. ± Comparison against base commit e278124.

@github-actions
Copy link

github-actions bot commented Apr 2, 2024

BigTest Unit Test Statistics

    1 files  ±0      1 suites  ±0   14s ⏱️ ±0s
471 tests ±0  435 ✔️ ±0  36 💤 ±0  0 ±0 
473 runs  ±0  437 ✔️ ±0  36 💤 ±0  0 ±0 

Results for commit 81779b6. ± Comparison against base commit e278124.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 2, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
28.6% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@JohnC-80 JohnC-80 mentioned this pull request Apr 2, 2024
@JohnC-80 JohnC-80 requested a review from zburke April 2, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants