Skip to content

Conversation

@Dmitriy-Litvinenko
Copy link
Contributor

@Dmitriy-Litvinenko Dmitriy-Litvinenko commented Jan 12, 2026

Purpose

Migration from mod-config and mod-settings to mod-circulation

Refs

https://issues.folio.org/browse/UICIRC-1247

@github-actions
Copy link

github-actions bot commented Jan 12, 2026

Jest Unit Test Results

    1 files  ±0    188 suites  +1   1m 19s ⏱️ +4s
1 997 tests  - 5  1 997 ✅  - 5  0 💤 ±0  0 ❌ ±0 
2 044 runs  +2  2 044 ✅ +2  0 💤 ±0  0 ❌ ±0 

Results for commit 09b5b85. ± Comparison against base commit 0dec590.

This pull request removes 35 and adds 30 tests. Note that renamed tests count towards both.
CheckoutSettings should execute `ConfigManager` with passed props ‑ CheckoutSettings should execute `ConfigManager` with passed props
CheckoutSettings should trigger TitleManager with correct props ‑ CheckoutSettings should trigger TitleManager with correct props
LoanHistorySettings getInitialValues method should get initial values when settings are not passed ‑ LoanHistorySettings getInitialValues method should get initial values when settings are not passed
LoanHistorySettings getInitialValues method should get initial values when settings are passed and settings are empty object ‑ LoanHistorySettings getInitialValues method should get initial values when settings are passed and settings are empty object
LoanHistorySettings getInitialValues method should get initial values when settings are passed and settings are not empty object ‑ LoanHistorySettings getInitialValues method should get initial values when settings are passed and settings are not empty object
LoanHistorySettings with default props should render "EntryManager" component ‑ LoanHistorySettings with default props should render "EntryManager" component
LoanHistorySettings with default props should trigger TitleManager with correct props ‑ LoanHistorySettings with default props should trigger TitleManager with correct props
PrintHoldRequests should connect "ConfigManager" to stripes ‑ PrintHoldRequests should connect "ConfigManager" to stripes
PrintHoldRequests should execute "ConfigManager" with passed props ‑ PrintHoldRequests should execute "ConfigManager" with passed props
PrintHoldRequests should trigger TitleManager with correct props ‑ PrintHoldRequests should trigger TitleManager with correct props
…
CheckoutSettings should render CirculationSettingsConfig with correct props ‑ CheckoutSettings should render CirculationSettingsConfig with correct props
CheckoutSettings should render TitleManager with correct props ‑ CheckoutSettings should render TitleManager with correct props
CirculationSettingsConfig should calls mutator with original data if onBeforeSave is not provided ‑ CirculationSettingsConfig should calls mutator with original data if onBeforeSave is not provided
CirculationSettingsConfig should calls onBeforeSave and mutator on submit ‑ CirculationSettingsConfig should calls onBeforeSave and mutator on submit
CirculationSettingsConfig should renders form with initial values and label ‑ CirculationSettingsConfig should renders form with initial values and label
LoanHistorySettings should render CirculationSettingsConfig with correct props ‑ LoanHistorySettings should render CirculationSettingsConfig with correct props
LoanHistorySettings should render TitleManager with correct props ‑ LoanHistorySettings should render TitleManager with correct props
PrintHoldRequests should render CirculationSettingsConfig with correct props ‑ PrintHoldRequests should render CirculationSettingsConfig with correct props
PrintHoldRequests should render TitleManager with correct props ‑ PrintHoldRequests should render TitleManager with correct props
TLRPatronNotices should render CirculationSettingsConfig with correct props ‑ TLRPatronNotices should render CirculationSettingsConfig with correct props
…

♻️ This comment has been updated with latest results.

@Dmitriy-Litvinenko Dmitriy-Litvinenko changed the title UICIRC-1307: Migration from mod-config and mod-settings to mod-circulation UICIRC-1247: Migration from mod-config and mod-settings to mod-circulation Jan 12, 2026
@Dmitriy-Litvinenko Dmitriy-Litvinenko requested a review from a team January 12, 2026 18:09
@Dmitriy-Litvinenko Dmitriy-Litvinenko requested a review from a team January 14, 2026 09:06

import {
CirculationSettingsConfig,
} from '../components';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably it makes sense to sort imports from far to close (../../../path to ../path)
ref https://folio-org.atlassian.net/wiki/spaces/FOLIJET/pages/1377187/Code+style+rules+not+covered+by+eslint

* Fixed new request policy form applied settings from previously edited request policy. Refs UICIRC-1293.
* Added global permissions for get read-access to values such as tenant’s locale, timezone, and currency. Refs UICIRC-1296.
* Update css for fix problem visibility Circulation rules. Refs UICIRC-1311.
* *BREAKING* Migration from mod-config and mod-settings to mod-circulation. Refs UICIRC-1247.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dmitriy-Litvinenko, the package.json major version should be bumped, and a new interface and permission should be added.

@sonarqubecloud
Copy link

@Dmitriy-Litvinenko Dmitriy-Litvinenko merged commit a3b059b into master Jan 29, 2026
15 checks passed
@Dmitriy-Litvinenko Dmitriy-Litvinenko deleted the UICIRC-1247 branch January 29, 2026 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants