-
Notifications
You must be signed in to change notification settings - Fork 9
UICIRC-1247: Migration from mod-config and mod-settings to mod-circulation #1259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Jest Unit Test Results 1 files ±0 188 suites +1 1m 19s ⏱️ +4s Results for commit 09b5b85. ± Comparison against base commit 0dec590. This pull request removes 35 and adds 30 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
692112d to
55dbe44
Compare
|
|
||
| import { | ||
| CirculationSettingsConfig, | ||
| } from '../components'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably it makes sense to sort imports from far to close (../../../path to ../path)
ref https://folio-org.atlassian.net/wiki/spaces/FOLIJET/pages/1377187/Code+style+rules+not+covered+by+eslint
| * Fixed new request policy form applied settings from previously edited request policy. Refs UICIRC-1293. | ||
| * Added global permissions for get read-access to values such as tenant’s locale, timezone, and currency. Refs UICIRC-1296. | ||
| * Update css for fix problem visibility Circulation rules. Refs UICIRC-1311. | ||
| * *BREAKING* Migration from mod-config and mod-settings to mod-circulation. Refs UICIRC-1247. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Dmitriy-Litvinenko, the package.json major version should be bumped, and a new interface and permission should be added.
55dbe44 to
d73e250
Compare
d73e250 to
09b5b85
Compare
|



Purpose
Migration from mod-config and mod-settings to mod-circulation
Refs
https://issues.folio.org/browse/UICIRC-1247