UIIN-3540: Add additionalCallNumber to versionHistory for holdings #2954
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OleksandrHladchenko1
approved these changes
Dec 26, 2025
zburke
approved these changes
Dec 30, 2025
Member
zburke
left a comment
zburke
left a comment
There was a problem hiding this comment.
Consider whether you want this to be implemented as a breaking change.
| isInitialLoading={isLoading} | ||
| fieldLabelsMap={fieldLabelsMap} | ||
| fieldFormatter={fieldFormatter} | ||
| itemFormatter={itemFormatter} |
Member
There was a problem hiding this comment.
itemFormatter was added to AuditLogPane in folio-org/stripes-components#2519 and will be available in the next version of @folio/stripes, likely 10.1.0. Since many breaking changes have already been added the next release of ui-inventory, consider bumping the deps on @folio/stripes in package.json to ^10.1.0.
Technically, passing new props to an existing function is backwards compatible; in an older version they'll be ignored but won't cause an error. Ultimately, up to you.
mariia-aloshyna
approved these changes
Jan 2, 2026
…ionHistory-for-holdings
…p version of folio/stripes to 10.1.0
…ionHistory-for-holdings
|
elsenhans
deleted the
UIIN-3540-add-additionalCallNumber-to-versionHistory-for-holdings
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Adding
additionalCallNumbersto the inventorys' holdings history as requested here:https://folio-org.atlassian.net/browse/UIIN-3559
https://folio-org.atlassian.net/browse/UIIN-3540
Instead of showing just the values of sub-fields as unnamed lists, we like to show the field name together with the sub-field value.
Adding sub-fields to
fieldLabelsMapfor these objects:additionalCallNumbersholdingsStatementsholdingsStatementsForSupplementsholdingsStatementsForIndexesnoteselectronicAccessentriesApproach
We define and pass a itemFormatter to the
AuditLogModalwhich allows us to display object properties as name-value pairs.Refs
folio-org/stripes-components#2519
folio-org/mod-audit#229
PR for inventory Items:
#2953
Screenshots
with itemFormatter (add fieldnames)
BEFORE or DEFAULT: without itemFormatter (no fieldnames)