UIU-3404: Migrate suppressEdit setting from mod-configuration to mod-users and custom_fields_label setting to mod-settings. Remove configuration interface.

[Dmytro-Melnyshyn]

Purpose

1. Migrate suppressEdit setting from mod-configuration to mod-users.
2. Migrate custom_fields_label setting from mod-configuration to mod-settings.

Approach

1. Removed suppressEdit from manifest in favor of the existing settings that uses users/settings/entries endpoint.
2. Passed a scope to stripes-smart-components and created new BE permissions.

Issues

https://folio-org.atlassian.net/browse/UIU-3404

TODOS and Open Questions

Learning

Pre-Merge Checklist

Before merging this PR, please go through the following list and take appropriate actions.

• I've added appropriate record to the CHANGELOG.md
• Does this PR meet or exceed the expected quality standards?
  • Code coverage on new code is 80% or greater
  • Duplications on new code is 3% or less
  • There are no major code smells or security issues
• Does this introduce breaking changes?
  • If any API-related changes - okapi interfaces and permissions are reviewed/changed correspondingly
  • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

• What other modules will these changes impact?
• Do JIRAs exist to update the impacted modules?
  • If not, please create them
  • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
  • Do they have all they appropriate links to blocked/related issues?
• Are the JIRAs under active development?
  • If not, contact the project's PO and make sure they're aware of the urgency.
• Do PRs exist for these changes?
  • If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

[github-actions]

Jest Unit Test Results

    1 files  ±0    273 suites   - 1   5m 43s ⏱️ -9s
1 306 tests  - 6  1 303 ✅  - 6  3 💤 ±0  0 ❌ ±0 
1 347 runs   - 6  1 344 ✅  - 6  3 💤 ±0  0 ❌ ±0 

Results for commit 226ab3b. ± Comparison against base commit e3f6c6b.

♻️ This comment has been updated with latest results.

[Dmytro-Melnyshyn]

Hi @zburke, as far as understand, the suppressEdit setting was created to prevent editing/deleting diku_admin and possibly other users. This setting contains an array of ids. Was it created for development purposes only? I'm asking to see if a note about the API change should be added to the release notes.

Related tickets:
https://folio-org.atlassian.net/browse/UIU-2499
https://folio-org.atlassian.net/browse/FOLIO-3394

[zburke]

Yes, @Dmytro-Melnyshyn, I think the impetus behind UIU-2499 was diku_admin in the dev-envs, but IIRC FSE also had a tenant that week who deleted EBSCO's admin users, and so there was a general feeling of "ya know, it would be nice if the UI made it a little harder to shoot yourself in the foot".

Since there is no data migration here, yes, I would put it in the release notes so folks know that step needs to happen manually.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud