Open
Conversation
Collaborator
|
Hi @hrdwrbob, we had a problem in the structure of the manifest file (it seems that Home Assistant decided that all entries must be alphabetically sorted from now on). That is the reason your validation failed. I updated the file, but you will need to resolve your merge conflict in order to be pushed into the code base. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes podcasts to work as any user would expect - it plays the podcast (not an episode - which is what it was doing), and it plays it from the first episode that hasn't been fully played, resumed at the point it was.
The previous way it worked would only ever play a single episode and then stop, and it didn't work in ways any user would reasonably expect - I have therefore also removed the ignore_fully_played option. I have added the position == 1 overload, which makes it search backwards, playing the latest unplayed episode first.
The main issue here is that you need to go through all the episodes and count the number yourself - you can't play a show with the uri of an episode. It works, but it's terrible.