-
Notifications
You must be signed in to change notification settings - Fork 393
Properly handle UI Test Config. #2827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| @@ -0,0 +1,11 @@ | |||
| { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is also a users section - see https://github.com/forcedotcom/SalesforceMobileSDK-iOS/blob/dev/native/SampleApps/AuthFlowTester/AuthFlowTesterUITests/test_config.json.sample
| ./install.sh | ||
| echo $TEST_CREDENTIALS > ./shared/test/test_credentials.json | ||
| echo $TEST_CONFIG > ./native/NativeSampleApps/AuthFlowTester/src/main/assets/test_config.json | ||
| echo $UI_TEST_CONFIG > ./shared/test/ui_test_config.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 ui_test_config is a better name than test_config.
I should rename on iOS also (and change the github actions there also)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I debated that name change because I didn't know if this could potentially be used to remove all consumer keys from the repo. But we can rethink about the naming if we do that in the future.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #2827 +/- ##
============================================
+ Coverage 63.06% 63.28% +0.21%
Complexity 2831 2831
============================================
Files 215 216 +1
Lines 17036 16997 -39
Branches 2465 2414 -51
============================================
+ Hits 10744 10756 +12
+ Misses 5124 5072 -52
- Partials 1168 1169 +1
🚀 New features to boost your workflow:
|
This PR moves the expected location of the
ui_test_config.jsonfile toshared/test/to matchtest_credentials.jsonand adds aui_test_config.json.samplefile.