Skip to content

Conversation

@bbirman
Copy link
Member

@bbirman bbirman commented Jan 13, 2026

No description provided.

@github-actions
Copy link

1 Error
🚫 Please re-submit this PR to the dev branch, we may have already fixed your issue.

Generated by 🚫 Danger

@github-actions
Copy link

1 Warning
⚠️ Static Analysis found an issue with one or more files you modified. Please fix the issue(s).

Clang Static Analysis Issues

File Type Category Description Line Col
SFRestAPI Nullability Memory error nil assigned to a pointer which is expected to have non-null value 98 5

Generated by 🚫 Danger

@github-actions
Copy link

TestsPassed ✅SkippedFailed
SalesforceSDKCore iOS ^18 Test Results494 ran494 ✅
TestResult
No test annotations available

@codecov
Copy link

codecov bot commented Jan 14, 2026

Codecov Report

❌ Patch coverage is 82.35294% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.55%. Comparing base (dc4699b) to head (6ace4d7).
⚠️ Report is 273 commits behind head on master.

Files with missing lines Patch % Lines
...Core/SalesforceSDKCore/Classes/RestAPI/SFRestAPI.m 82.35% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3969      +/-   ##
==========================================
+ Coverage   61.44%   62.55%   +1.11%     
==========================================
  Files         233      250      +17     
  Lines       21699    22495     +796     
==========================================
+ Hits        13332    14072     +740     
- Misses       8367     8423      +56     
Components Coverage Δ
Analytics 70.78% <ø> (ø)
Common 70.58% <98.27%> (+1.51%) ⬆️
Core 52.46% <72.02%> (+2.30%) ⬆️
SmartStore 73.66% <ø> (-0.02%) ⬇️
MobileSync 87.66% <ø> (-0.10%) ⬇️
Files with missing lines Coverage Δ
...Core/SalesforceSDKCore/Classes/RestAPI/SFRestAPI.m 89.05% <82.35%> (+0.41%) ⬆️

... and 70 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

TestsPassed ☑️SkippedFailed ❌️
SalesforceSDKCore iOS ^26 Test Results494 ran491 ✅3 ❌
TestResult
SalesforceSDKCore iOS ^26 Test Results
SFSDKEncryptedPushNotificationTests.testNotificationTransformNonRSASecret❌ failure
SFUserAccountManagerTests.testAuthHandler❌ failure
SFUserAccountManagerTests.testUserAccountEncoding (failure 1/3)❌ failure
SFUserAccountManagerTests.testUserAccountEncoding (failure 2/3)❌ failure
SFUserAccountManagerTests.testUserAccountEncoding (failure 3/3)❌ failure

@bbirman bbirman merged commit 4be70e8 into forcedotcom:master Jan 14, 2026
20 of 27 checks passed
@bbirman bbirman deleted the rest-cherry-pick branch January 14, 2026 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants