-
Notifications
You must be signed in to change notification settings - Fork 429
Merge master -> dev #3970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Merge master -> dev #3970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-pick Cherry pick actionable notifications options fix for patch
Cherry pick welcome flag for patch
Cherry pick RestAPI callback fix for patch
wmathurin
approved these changes
Jan 15, 2026
Remove welcome discovery flag
Clang Static Analysis Issues
Generated by 🚫 Danger |
|
||||||||||||||||
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## dev #3970 +/- ##
===========================================
- Coverage 63.44% 52.42% -11.03%
===========================================
Files 252 191 -61
Lines 22137 15677 -6460
===========================================
- Hits 14044 8218 -5826
+ Misses 8093 7459 -634
🚀 New features to boost your workflow:
|
|
||||||||||||||||
Remove welcome from default server list
wmathurin
approved these changes
Jan 22, 2026
Member
Author
|
Failing test is passing locally and has flapped before, will investigate more separately |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was one conflict in RestClientTest.swift because #3964 is in
devbut notmaster