Skip to content

Conversation

@bbirman
Copy link
Member

@bbirman bbirman commented Jan 15, 2026

There was one conflict in RestClientTest.swift because #3964 is in dev but not master

@github-actions
Copy link

1 Warning
⚠️ Static Analysis found an issue with one or more files you modified. Please fix the issue(s).

Clang Static Analysis Issues

File Type Category Description Line Col
SalesforceSDKManager Nil value used as mutex for @synchronized() (no synchronization will occur) Logic error Nil value used as mutex for @synchronized() (no synchronization will occur) 144 5
SalesforceSDKManager Nil value used as mutex for @synchronized() (no synchronization will occur) Logic error Nil value used as mutex for @synchronized() (no synchronization will occur) 156 5

Generated by 🚫 Danger

@github-actions
Copy link

github-actions bot commented Jan 21, 2026

TestsPassed ☑️SkippedFailed ❌️
SalesforceSDKCore iOS ^26 Test Results585 ran584 ✅1 ❌
TestResult
SalesforceSDKCore iOS ^26 Test Results
DomainDiscoveryCoordinatorTests.testCallbackSuccess()❌ failure

@codecov
Copy link

codecov bot commented Jan 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52.42%. Comparing base (e8a07ac) to head (f79da2c).
⚠️ Report is 20 commits behind head on dev.

❗ There is a different number of reports uploaded between BASE (e8a07ac) and HEAD (f79da2c). Click for more details.

HEAD has 12 uploads less than BASE
Flag BASE (e8a07ac) HEAD (f79da2c)
SalesforceSDKCore 14 2
Additional details and impacted files
@@             Coverage Diff             @@
##              dev    #3970       +/-   ##
===========================================
- Coverage   63.44%   52.42%   -11.03%     
===========================================
  Files         252      191       -61     
  Lines       22137    15677     -6460     
===========================================
- Hits        14044     8218     -5826     
+ Misses       8093     7459      -634     
Components Coverage Δ
Analytics 40.98% <ø> (-29.81%) ⬇️
Common 56.22% <ø> (-13.55%) ⬇️
Core 52.47% <100.00%> (-1.60%) ⬇️
SmartStore ∅ <ø> (∅)
MobileSync ∅ <ø> (∅)
Files with missing lines Coverage Δ
...forceSDKCore/Classes/Common/SalesforceSDKManager.m 69.45% <ø> (-0.11%) ⬇️
...re/Classes/Login/DevConfig/AuthFlowTypesView.swift 90.90% <ø> (+1.25%) ⬆️
...re/Classes/Login/LoginHost/SFSDKLoginHostStorage.m 60.25% <ø> (-1.00%) ⬇️
...ore/Classes/OAuth/DomainDiscoveryCoordinator.swift 85.71% <100.00%> (-0.83%) ⬇️

... and 84 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

github-actions bot commented Jan 21, 2026

TestsPassed ☑️SkippedFailed ❌️
SalesforceSDKCore iOS ^18 Test Results585 ran584 ✅1 ❌
TestResult
SalesforceSDKCore iOS ^18 Test Results
DomainDiscoveryCoordinatorTests.testCallbackSuccess()❌ failure

@bbirman
Copy link
Member Author

bbirman commented Jan 22, 2026

Failing test is passing locally and has flapped before, will investigate more separately

@bbirman bbirman merged commit 306c5a0 into forcedotcom:dev Jan 22, 2026
22 of 27 checks passed
@bbirman bbirman deleted the patch-merge branch January 22, 2026 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants