Skip to content

Conversation

@bbirman
Copy link
Member

@bbirman bbirman commented Jan 20, 2026

No description provided.

@github-actions
Copy link

1 Error
🚫 Please re-submit this PR to the dev branch, we may have already fixed your issue.

Generated by 🚫 Danger

@github-actions
Copy link

1 Warning
⚠️ Static Analysis found an issue with one or more files you modified. Please fix the issue(s).

Clang Static Analysis Issues

File Type Category Description Line Col
SalesforceSDKManager Nil value used as mutex for @synchronized() (no synchronization will occur) Logic error Nil value used as mutex for @synchronized() (no synchronization will occur) 144 5
SalesforceSDKManager Nil value used as mutex for @synchronized() (no synchronization will occur) Logic error Nil value used as mutex for @synchronized() (no synchronization will occur) 156 5

Generated by 🚫 Danger

@brandonpage
Copy link
Contributor

Build fails with:
xcodebuild: error: The workspace named "SalesforceMobileSDK" does not contain a scheme named "AuthFlowTester". The "-list" option can be used to find the names of the schemes in the workspace.

Should be expected when building against master.

@github-actions
Copy link

TestsPassed ☑️SkippedFailed ❌️
SalesforceSDKCore iOS ^26 Test Results494 ran492 ✅2 ❌
TestResult
SalesforceSDKCore iOS ^26 Test Results
SFSDKEncryptedPushNotificationTests.testNotificationTransformNonRSASecret❌ failure
SFUserAccountManagerTests.testUserAccountEncoding❌ failure

@codecov
Copy link

codecov bot commented Jan 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.40%. Comparing base (fd5b602) to head (e76ae69).
⚠️ Report is 11 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3972      +/-   ##
==========================================
- Coverage   62.52%   62.40%   -0.13%     
==========================================
  Files         250      250              
  Lines       22480    22474       -6     
==========================================
- Hits        14055    14024      -31     
- Misses       8425     8450      +25     
Components Coverage Δ
Analytics 70.78% <ø> (ø)
Common 70.58% <ø> (ø)
Core 52.20% <81.81%> (-0.20%) ⬇️
SmartStore 73.66% <ø> (ø)
MobileSync 87.66% <ø> (ø)
Files with missing lines Coverage Δ
...forceSDKCore/Classes/Common/SalesforceSDKManager.m 57.06% <ø> (ø)
...ore/Classes/OAuth/DomainDiscoveryCoordinator.swift 85.71% <100.00%> (-4.29%) ⬇️

... and 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

TestsPassed ✅SkippedFailed
SalesforceSDKCore iOS ^18 Test Results494 ran494 ✅
TestResult
No test annotations available

@bbirman
Copy link
Member Author

bbirman commented Jan 20, 2026

For the test failures, one of them was fixed in dev (#3937) and the other is a known flapper (need to fix but unrelated to welcome)

@bbirman bbirman merged commit 2758cc6 into forcedotcom:master Jan 20, 2026
21 of 27 checks passed
@bbirman bbirman deleted the welcomeFlag branch January 21, 2026 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants