-
Notifications
You must be signed in to change notification settings - Fork 429
Add user agent to token calls #3975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| @end | ||
|
|
||
| SFSDK_DEPRECATED(13.2, 14.0, "Will be removed.") | ||
| @protocol SFSDKOAuthSessionManaging<NSObject> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there used to be more in this protocol but I don't see it used anywhere (even for mocking) so I don't think it needs to be public, the one method was used as a helper method for SFNetwork and with this change it's not needed
Clang Static Analysis Issues
Generated by 🚫 Danger |
|
||||||||||||||||||||||
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (66.66%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## dev #3975 +/- ##
==========================================
- Coverage 63.44% 63.42% -0.02%
==========================================
Files 252 252
Lines 22137 22143 +6
==========================================
+ Hits 14044 14045 +1
- Misses 8093 8098 +5
🚀 New features to boost your workflow:
|
|
||||||||||||||||
Confirmed with Charles that Android includes the MSDK user agent on the equivalent requests for
accessTokenForApprovalCodeandaccessTokenForRefresh, updating iOS to match