Skip to content

Conversation

@Quentin-David-24
Copy link
Contributor

@Quentin-David-24 Quentin-David-24 commented Dec 11, 2025

Improve error message for create-link and update-link operations when the Payment Service User (PSU) has not been forwarded to the connector.

Previously, calling create-link or update-link without a pre-forwarded PSU resulted in a generic "not found" error. This change provides a specific error message guiding the user to first forward the PSU to the connector.


Slack Thread

Open in Cursor Open in Web


Summary by cubic

Adds clear validation errors for create-link and update-link when the PSU hasn’t been forwarded to the connector, replacing the generic “not found” response. This guides users to forward the PSU before linking.

  • Bug Fixes
    • Engine maps storage.ErrNotFound to a validation error with an actionable message for both create and update link flows.
    • Tests updated: unit tests assert the new error text; added an e2e test for create-link without a forwarded PSU.

Written for commit 06102d4. Summary will update automatically on new commits.

Co-authored-by: quentin <quentin@formance.com>
@cursor
Copy link

cursor bot commented Dec 11, 2025

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 11, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch cursor/improve-create-link-error-handling-39a9

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants