-
Notifications
You must be signed in to change notification settings - Fork 155
chore: webcheckin vite migration #1317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Saksham-Sirohi
wants to merge
6
commits into
fossasia:enext
Choose a base branch
from
Saksham-Sirohi:webcheckin-vue-migration
base: enext
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
chore: webcheckin vite migration #1317
Saksham-Sirohi
wants to merge
6
commits into
fossasia:enext
from
Saksham-Sirohi:webcheckin-vue-migration
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fossasia#1157) * Fix navigation button border radius inconsistency - Added border-radius: 0 to .header-nav class in orga/_layout.css - Makes Talk component navigation buttons match Tickets component style - Ensures consistent sharp corners across all navigation buttons - Maintains visual consistency throughout the platform Fixes fossasia#1156 * Add inset shadow on hover to match Tickets component - Added hover and active states with inset box-shadow - Matches the hover effect from btn-success in Tickets component - Uses rgba(0, 128, 0, 0.25) for green inset shadow * Fix navigation button active state to match Tickets component - Added .header-nav.active state with proper inset shadow - Fixed depth and consistency of hover, active, and current page states - Current page button now has same darker border effect as Tickets - All navigation buttons now have identical visual feedback * Improve CSS: use variables and remove important declarations * Fix CSS indentation formatting * Update app/eventyay/static/orga/css/_layout.css * Update app/eventyay/static/orga/css/_layout.css * Fix navigation buttons: sharp corners and inset shadow to match Tickets component --------- Co-authored-by: Mario Behling <mb@mariobehling.de>
* talk: remove ticket/video URL fields * talk: normalize ticket base URL * Update app/eventyay/agenda/views/talk.py --------- Co-authored-by: Mario Behling <mb@mariobehling.de>
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR migrates the webcheckin plugin to a Vite‐based build by relocating source files into the plugin directory, removing the legacy static folder, and updating code references from “item” to “product” in the search result component. Class diagram for updated SearchResultItem componentclassDiagram
class SearchResultItem {
+position: Object
+productvar(): String
+subevent(): String
+status(): String
}
SearchResultItem : productvar() replaces itemvar()
SearchResultItem : productvar uses position.product.name
SearchResultItem : productvar uses position.variation.value
SearchResultItem : subevent uses position.subevent
SearchResultItem : status uses position.checkins and position.order__status
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
migration of webcheckin to vite
Summary by Sourcery
Migrate the webcheckin plugin’s frontend to Vite by relocating Vue components and assets under the new plugins directory, removing legacy static files, and updating component code for product naming consistency.
Enhancements:
Build: