Skip to content

Conversation

@Eshaan-byte
Copy link

@Eshaan-byte Eshaan-byte commented Nov 29, 2025

Description

Changed event name header from <h1> to <h2> in Tickets and Common dashboards to match the Talk Dashboard typography for visual consistency across the unified platform.

Changes

  • Updated pretixcontrol/event/index.html (Tickets Dashboard)
  • Updated eventyay_common/event/index.html (Common Dashboard)

Result

All three dashboards now use consistent typography for event name headers:

  • Font size: 1.75rem (h2)
  • Font weight: 500
  • Line height: 1.2

Testing

  • Verified Tickets Dashboard displays event name with h2 styling
  • Verified Common Dashboard displays event name with h2 styling
  • Confirmed consistency with Talk Dashboard

Fixes #1368

Summary by Sourcery

Align event name header typography across dashboards by standardizing the heading level.

Enhancements:

  • Change event name headers from h1 to h2 on the Tickets dashboard for consistent visual hierarchy.
  • Change event name headers from h1 to h2 on the Common dashboard to match the Talk dashboard styling.

marvel at flowers and others added 30 commits October 10, 2025 07:32
Currently translated at 0.1% (3 of 4121 strings)

Translation: eventyay/Eventyay Tickets
Translate-URL: https://hosted.weblate.org/projects/open-event/eventyay-tickets/zh_Hant/
Currently translated at 0.2% (9 of 4121 strings)

Translation: eventyay/Eventyay Tickets
Translate-URL: https://hosted.weblate.org/projects/open-event/eventyay-tickets/zh_Hant/
Currently translated at 0.4% (18 of 4121 strings)

Translation: eventyay/Eventyay Tickets
Translate-URL: https://hosted.weblate.org/projects/open-event/eventyay-tickets/pl_INFORMAL/
Currently translated at 2.9% (123 of 4121 strings)

Translation: eventyay/eventyay
Translate-URL: https://hosted.weblate.org/projects/eventyay/eventyay/zh_Hant/
Currently translated at 2.9% (123 of 4121 strings)

Translation: eventyay/eventyay
Translate-URL: https://hosted.weblate.org/projects/eventyay/eventyay/zh_Hant/
The issue was caused by unconditional access to test_form.cleaned_data
without checking if the form validation succeeded. When test_form.is_valid()
returned False, accessing cleaned_data could raise AttributeError or return
incomplete data, causing a 500 error.

Solution: Added conditional check to only access cleaned_data when form is
valid, otherwise use empty dict for initial values. This ensures the export
page loads properly even when no valid GET parameters are provided.

Changes:
- Modified ExportMixin.exporters property in control/views/orders.py
- Added validation check before accessing test_form.cleaned_data
- Fallback to empty dict when form is invalid
Applied the same fix from issueto the organizer-level export
functionality. The ExportMixin in organizer.py had the identical issue
where test_form.cleaned_data was accessed without checking if the form
validation succeeded first.

This prevents potential HTTP 500 errors when accessing:
- /control/organizer/{organizer}/export/

Changes:
- Modified ExportMixin.exporters in control/views/organizer.py
- Added validation check before accessing test_form.cleaned_data
- Fallback to empty dict when form is invalid
- Use f-strings instead of string concatenation for better readability
- Rename 'id' variable to 'identifier' to avoid shadowing builtin
- Apply improvements to both orders.py and organizer.py

Addresses Sourcery suggestions...
- Add JSON_FIELD_AVAILABLE setting based on database backend (postgresql = True)
- Fix checkinlists exporter using old Event.items instead of Event.products
- Resolves AttributeError when accessing export functionality
- Changed from if/else validation check to getattr() to preserve partial cleaned_data
- This allows useful defaults even when form is partially invalid
- Reverted unnecessary 'id' to 'identifier' rename in organizer.py
- Renamed 'items' field to 'products' in checkinlists exporter for consistency
- Updated form_data['items'] to form_data['products'] reference
…fossasia#1157)

* Fix navigation button border radius inconsistency

- Added border-radius: 0 to .header-nav class in orga/_layout.css
- Makes Talk component navigation buttons match Tickets component style
- Ensures consistent sharp corners across all navigation buttons
- Maintains visual consistency throughout the platform

Fixes fossasia#1156

* Add inset shadow on hover to match Tickets component

- Added hover and active states with inset box-shadow
- Matches the hover effect from btn-success in Tickets component
- Uses rgba(0, 128, 0, 0.25) for green inset shadow

* Fix navigation button active state to match Tickets component

- Added .header-nav.active state with proper inset shadow
- Fixed depth and consistency of hover, active, and current page states
- Current page button now has same darker border effect as Tickets
- All navigation buttons now have identical visual feedback

* Improve CSS: use variables and remove important declarations

* Fix CSS indentation formatting

* Update app/eventyay/static/orga/css/_layout.css

* Update app/eventyay/static/orga/css/_layout.css

* Fix navigation buttons: sharp corners and inset shadow to match Tickets component

---------

Co-authored-by: Mario Behling <mb@mariobehling.de>
* talk: remove ticket/video URL fields

* talk: normalize ticket base URL

* Update app/eventyay/agenda/views/talk.py

---------

Co-authored-by: Mario Behling <mb@mariobehling.de>
MohammedAnasNathani and others added 15 commits November 28, 2025 13:36
i18n(translations): update localized strings from Weblate
…sasia#1321)

* fix: Resolve multiple exporter failures after database migration

* Update app/eventyay/base/exporters/waitinglist.py

* removed redundant length checks in reports exporter

* Update app/eventyay/plugins/ticketoutputpdf/exporters.py

* Update app/eventyay/plugins/checkinlists/exporters.py

* Update app/eventyay/plugins/badges/exporters.py

* fix: remove duplicate JSON_FIELD_AVAILABLE definition

---------

Co-authored-by: Mario Behling <mb@mariobehling.de>
Co-authored-by: Srivatsav Auswin <75414859+Sak1012@users.noreply.github.com>
…fossasia#1331)

* fixed featured sessions and 500 errors on sessions and reviews

* implemented suggestions

---------

Co-authored-by: Mario Behling <mb@mariobehling.de>
Co-authored-by: Mario Behling <mb@mariobehling.de>
* urls fix

* fix pages and schedule communication

* implemented suggestions

---------

Co-authored-by: Mario Behling <mb@mariobehling.de>
Currently translated at 85.9% (3543 of 4121 strings)

Translation: eventyay/eventyay
Translate-URL: https://hosted.weblate.org/projects/eventyay/eventyay/pt_PT/
* Fix missing CSS regeneration

* Update app/eventyay/eventyay_common/views/event.py

---------

Co-authored-by: Mario Behling <mb@mariobehling.de>
…iles (fossasia#1370)

* fix(locale): Remove old translation files introduced by weblate

The updated translation files are already available in the new `enext`
system under `app/eventyay/locale`.

* fix(locale): Merge redundant language files
i18n(translations): update localized strings from Weblate
)

Changed event name header from h1 to h2 in Tickets and Common dashboards
to match the Talk Dashboard typography for visual consistency.

- Updated pretixcontrol/event/index.html (Tickets Dashboard)
- Updated eventyay_common/event/index.html (Common Dashboard)

This ensures all three dashboards use consistent font size (1.75rem),
weight (500), and line height (1.2) for event name headers.

Fixes fossasia#1368
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Nov 29, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Standardizes the event name header typography across the Tickets and Common dashboards by changing the event title markup from h1 to h2 to match the Talk Dashboard.

File-Level Changes

Change Details Files
Align event title heading level with Talk Dashboard for consistent typography across dashboards.
  • Change the event title container from an h1 to an h2 element in the Tickets dashboard event index template, keeping the existing inner content and logic unchanged.
  • Change the event title container from an h1 to an h2 element in the Common dashboard event index template, keeping the existing inner content and logic unchanged.
app/eventyay/control/templates/pretixcontrol/event/index.html
app/eventyay/eventyay_common/templates/eventyay_common/event/index.html

Assessment against linked issues

Issue Objective Addressed Explanation
#1368 Update the Tickets Dashboard event name header to use the same typography (via heading level/styling hook) as the Talk Dashboard.
#1368 Update the Common Dashboard event name header to use the same typography (via heading level/styling hook) as the Talk Dashboard.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • Since the main event title has been downgraded to an h2, double-check the surrounding template/layout to ensure there is still a meaningful top-level h1 on these pages for semantic heading structure and accessibility.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Since the main event title has been downgraded to an h2, double-check the surrounding template/layout to ensure there is still a meaningful top-level h1 on these pages for semantic heading structure and accessibility.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@Eshaan-byte
Copy link
Author

@sourcery-ai Thanks for the review!

Regarding the h1 concern: This change aligns the Tickets and Common dashboards with the existing Talk Dashboard pattern, which also uses <h2> for the event name header. The Talk Dashboard includes <h1> elements within the dashboard content tiles themselves.

For semantic consistency across all three dashboards (which is the goal of this PR), we're maintaining this pattern. If there's a broader accessibility concern about heading structure across all dashboards, that could be addressed in a separate issue/PR that updates all three dashboards uniformly.

The primary goal here was typography consistency as requested in #1368.

@mariobehling mariobehling requested a review from Copilot November 30, 2025 05:26
Copy link
Member

@mariobehling mariobehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Please add screenshots showing changes.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

Match event name header font and size on Tickets and Common Dashboard to Talk Dashboard