added dark and light mode button #25
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sakshee-19
reviewed
Jan 5, 2019
css/stylesheet.css
Outdated
| margin: 4px 2px; | ||
| cursor: pointer; | ||
| border-radius: 50%; | ||
| } No newline at end of file |
| let out = document.getElementById("out") | ||
| let flag=0 | ||
|
|
||
|
|
js/main.js
Outdated
| } | ||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
Remove extra unnecessary empty lines.
sakshee-19
reviewed
Jan 6, 2019
sakshee-19
left a comment
sakshee-19
left a comment
There was a problem hiding this comment.
Please squash your commits and provide a preview link to test the changes.
Author
|
preview link : https://armish24.github.io/geolocation/ |
abishekvashok
suggested changes
Jan 7, 2019
js/main.js
Outdated
| {document.body.style.background = 'black'; | ||
| document.getElementById("title").style.color = 'white'; | ||
| document.getElementById("myButton1").value="Light"; | ||
| document.getElementById("myButton1").style.background = 'white'; |
Author
There was a problem hiding this comment.
I modified the code, to minimize size of code .Kindly have a look
abishekvashok
suggested changes
Jan 9, 2019
| </head> | ||
| <body> | ||
| <h2>Geo locator to faciliate easy integration of location data</h2> | ||
| <input type="button" value="Dark" id="myButton1" onclick="changeBodyBg();"></input> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the feature of dark and light mode in main page.
SCREENSHOTS
LIGHT MODE :-
DARK MODE :-